----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66503/#review200780 -----------------------------------------------------------
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java Line 308 (original), 305 (patched) <https://reviews.apache.org/r/66503/#comment281644> (It would be good to point out that this is based on an estimation, not the exact memory footprint). The maximum memory in bytes that the cached objects can use. Memory used is calculated based on estimated size of tables and partitions in the cache. standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java Lines 165 (patched) <https://reviews.apache.org/r/66503/#comment281645> I see LLAP uses HiveConf.getSizeVar(conf, ConfVars.LLAP_IO_MEMORY_MAX_SIZE); to get a type of size can you please check if MetastoreConf.getLongVar(conf, ConfVars.CACHED_RAW_STORE_MAX_CACHE_MEMORY) does the conversion to bytes ? - Thejas Nair On April 9, 2018, 10:42 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66503/ > ----------------------------------------------------------- > > (Updated April 9, 2018, 10:42 p.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-19126 > https://issues.apache.org/jira/browse/HIVE-19126 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-19126 > > > Diffs > ----- > > > llap-server/src/java/org/apache/hadoop/hive/llap/IncrementalObjectSizeEstimator.java > 6f4ec6f1ea > > llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcFileEstimateErrors.java > 2f7fa24558 > > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestIncrementalObjectSizeEstimator.java > 0bbaf7e459 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > c47856de87 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/SharedCache.java > 89b400697b > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > 940a1bf276 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/SizeValidator.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/66503/diff/2/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
