> On April 17, 2018, 3:24 a.m., Eugene Koifman wrote: > > common/src/java/org/apache/hadoop/hive/common/JavaUtils.java > > Line 219 (original), 218 (patched) > > <https://reviews.apache.org/r/66414/diff/2/?file=1993097#file1993097line219> > > > > what is the purpose of this if block? seems to do nothing useful
some old code used to rely on this when matching logic was different, to locate (or skip) manifest directories - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66414/#review201287 ----------------------------------------------------------- On April 5, 2018, 7:24 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66414/ > ----------------------------------------------------------- > > (Updated April 5, 2018, 7:24 p.m.) > > > Review request for hive and Eugene Koifman. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 75c07b41b2 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java > 0168472bdc > itests/src/test/resources/testconfiguration.properties d2e077b509 > ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 7eba5e88d8 > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 5fbe045df5 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java eed37a1937 > ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java > e49089b91e > ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java b0dfc48165 > ql/src/test/results/clientpositive/mm_loaddata.q.out > > > Diff: https://reviews.apache.org/r/66414/diff/2/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
