> On April 23, 2018, 5:04 a.m., Gopal V wrote: > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > > Lines 353 (patched) > > <https://reviews.apache.org/r/66485/diff/7/?file=2008368#file2008368line356> > > > > Add a timestamp to the tmp-table and fail-retry if it already exists. > > > > Dropping it might make it harder to debug this.
This is a temporary table... it may be gone anyway. If not, this might necessitate a follow-up for cleanup of these failed tables. > On April 23, 2018, 5:04 a.m., Gopal V wrote: > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > > Lines 1236 (patched) > > <https://reviews.apache.org/r/66485/diff/7/?file=2008368#file2008368line1244> > > > > Add comment about not needing locks because these are insert-only > > tables and the base writer doesn't need locks anyway. Hmm? Can you elaborate? The tmp table is session scoped and not insert only, so we don't need any locks. The original query locks are taken care of by driver. It's anyway a read query. - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66485/#review201717 ----------------------------------------------------------- On April 20, 2018, 11:15 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66485/ > ----------------------------------------------------------- > > (Updated April 20, 2018, 11:15 p.m.) > > > Review request for hive and Eugene Koifman. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 536c7b427f > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java > 82ba775286 > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 9cb2ff1015 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java c8cb8a40b4 > ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java dde20ed56e > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > b1c2288d01 > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java > 22765b8e63 > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java fe0aaa4ff5 > ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommandsForMmTable.java > c053860b36 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/hive_metastoreConstants.java > cb1d40a4a8 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnUtils.java > 7b02865e18 > > storage-api/src/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java > 107ea9028a > > > Diff: https://reviews.apache.org/r/66485/diff/7/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
