----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67636/#review205203 -----------------------------------------------------------
ql/src/test/org/apache/hadoop/hive/ql/exec/spark/status/TestSparkJobMonitor.java Lines 96 (patched) <https://reviews.apache.org/r/67636/#comment288136> why does testOutput contain both formats? also there is a unnecessary pair of "()" here ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/RenderStrategy.java Lines 54 (patched) <https://reviews.apache.org/r/67636/#comment288131> since this is a constant, can you make it static. FindBugs is complaining about it: "Unread field:field be static? At RenderStrategy.java:[line 47]" ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/RenderStrategy.java Lines 152-154 (patched) <https://reviews.apache.org/r/67636/#comment288133> use `progressMap.entrySet` for this instead. FindBugs is complaining about it "org.apache.hadoop.hive.ql.exec.spark.status.RenderStrategy$BaseUpdateFunction.isSameAsPreviousProgress(Map, Map) makes inefficient use of keySet iterator instead of entrySet iterator At RenderStrategy.java:of keySet iterator instead of entrySet iterator At RenderStrategy.java:[line 147]" ql/src/test/org/apache/hadoop/hive/ql/exec/spark/TestSparkTask.java Lines 108 (patched) <https://reviews.apache.org/r/67636/#comment288134> why is this necessary? - Sahil Takiar On June 21, 2018, 3:50 p.m., Bharathkrishna Guruvayoor Murali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67636/ > ----------------------------------------------------------- > > (Updated June 21, 2018, 3:50 p.m.) > > > Review request for hive, Peter Vary, Sahil Takiar, and Vihang Karajgaonkar. > > > Repository: hive-git > > > Description > ------- > > This logic is similar to the RenderStrategy used in Tez to print the progress > bar. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > e7f5fc0c6a3d527671c354db8ef2c9772aab6dd0 > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java > ad8d1a7f1cca3a763bb7c07335998ab7d39d7598 > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/LocalSparkJobMonitor.java > 2a6c33bfd4824c96e7004cd1ecce48c62c97d685 > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/RemoteSparkJobMonitor.java > 004b50ba95934280cf302055a46a5d984b421e07 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/RenderStrategy.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java > 3531ac25a9959aacd5766a9a42316890c68a1cd5 > ql/src/test/org/apache/hadoop/hive/ql/exec/spark/TestSparkTask.java > 368fa9f1fa3ccc8b78cc4f9e98acf352cbc1c4c3 > > ql/src/test/org/apache/hadoop/hive/ql/exec/spark/status/TestSparkJobMonitor.java > e66354f0869738bd3cf0eb831c13fa6af1eda256 > service/src/java/org/apache/hive/service/ServiceUtils.java > 226e43244df10c22143b91f92ef312e56739d036 > > service/src/java/org/apache/hive/service/cli/SparkProgressMonitorStatusMapper.java > PRE-CREATION > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > 68fe8d8aa143fafbfc611253ce3a12065016a537 > > > Diff: https://reviews.apache.org/r/67636/diff/2/ > > > Testing > ------- > > > Thanks, > > Bharathkrishna Guruvayoor Murali > >
