----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67753/#review205421 -----------------------------------------------------------
Thanks for the patch! Good to have these guards in place, so the user will not shoot themselves on their legs standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Lines 1260 (patched) <https://reviews.apache.org/r/67753/#comment288324> Probably it would be good to check the conf first, and check the existance of the directory only it is required by the conf. Checking the FS can take some time. Are we sure that the location is not null at this stage? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestMetaCreateObjects.java Lines 52 (patched) <https://reviews.apache.org/r/67753/#comment288325> When starting an Embedded metastore, please set the jdbc url to a unique value, like here: https://github.com/apache/hive/blob/master/standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/MetaStoreFactoryForTests.java#L89-L90 Otherwise when multiple test run in parallel they will start the same derby database for their tests which can cause unexpected problems. standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestMetaCreateObjects.java Lines 79 (patched) <https://reviews.apache.org/r/67753/#comment288322> Have you checked, that we really need this? AFAIK setting locationUri should be enough standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestMetaCreateObjects.java Lines 103 (patched) <https://reviews.apache.org/r/67753/#comment288323> Have you checked, that we really need this? AFAIK setting locationUri should be enough - Peter Vary On jún. 27, 2018, 10:42 de, Oleksiy Sayankin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67753/ > ----------------------------------------------------------- > > (Updated jún. 27, 2018, 10:42 de) > > > Review request for hive, Zoltan Haindrich and Zoltan Haindrich. > > > Repository: hive-git > > > Description > ------- > > Added hive.metastore.allow.new.db.in.existing.directory property > > > Diffs > ----- > > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > e9d7e7c397 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > f3b909ca44 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java > 963e12f9d8 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestMetaCreateObjects.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/67753/diff/2/ > > > Testing > ------- > > > Thanks, > > Oleksiy Sayankin > >
