----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67801/#review205844 -----------------------------------------------------------
Looks good. Might be good idea to have a test for this. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java Line 307 (original), 307 (patched) <https://reviews.apache.org/r/67801/#comment288745> Thanks, for catching this! Do we have tests to confirm that we use this correctly now, and it will not regress? - Peter Vary On júl. 3, 2018, 12:28 de, Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67801/ > ----------------------------------------------------------- > > (Updated júl. 3, 2018, 12:28 de) > > > Review request for hive, Andrew Sherman, Janaki Lahorani, Peter Vary, Sahil > Takiar, and Vihang Karajgaonkar. > > > Bugs: HIVE-19337 > https://issues.apache.org/jira/browse/HIVE-19337 > > > Repository: hive-git > > > Description > ------- > > HIVE-19337 Partition whitelist regex doesn't work (and never did) > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > ba46e63839e4b02d325007b16756ccd8f3240f63 > > > Diff: https://reviews.apache.org/r/67801/diff/1/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
