> On July 19, 2018, 12:25 a.m., Vihang Karajgaonkar wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > > Lines 111-116 (patched) > > <https://reviews.apache.org/r/67954/diff/1/?file=2061290#file2061290line111> > > > > Do you think we can get these values from a config instead of hard > > coding?
Hmm, it is possible, I am not sure whether it is worth introducing a config variable fo this. This is a one-off case. Do you think it is better to make configurable? - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67954/#review206230 ----------------------------------------------------------- On July 18, 2018, 12:10 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67954/ > ----------------------------------------------------------- > > (Updated July 18, 2018, 12:10 a.m.) > > > Review request for hive, Alan Gates, Peter Vary, Sahil Takiar, and Vihang > Karajgaonkar. > > > Bugs: HIVE-20194 > https://issues.apache.org/jira/browse/HIVE-20194 > > > Repository: hive-git > > > Description > ------- > > HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded > HMS instance > > > Diffs > ----- > > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 47f819b60a6c7eb2acac9217724e67a976341093 > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 92e280570f44cd56fe87c3123001b9263d28186f > > standalone-metastore/metastore-common/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java > d91f737450efa9de6db3806401072645c96bbb7d > > > Diff: https://reviews.apache.org/r/67954/diff/1/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
