----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67974/#review206291 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java Lines 1672 (patched) <https://reviews.apache.org/r/67974/#comment289187> Remove these comments? ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java Lines 1695 (patched) <https://reviews.apache.org/r/67974/#comment289188> please add curly braces ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java Lines 1701 (patched) <https://reviews.apache.org/r/67974/#comment289189> curly braces ql/src/test/queries/clientpositive/murmur_hash_migration.q Lines 36 (patched) <https://reviews.apache.org/r/67974/#comment289194> Does this test also need to query the inserted tables to show that things are working properly? - Jason Dere On July 19, 2018, 6:02 p.m., Deepak Jaiswal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67974/ > ----------------------------------------------------------- > > (Updated July 19, 2018, 6:02 p.m.) > > > Review request for hive, Gopal V and Jason Dere. > > > Bugs: HIVE-20164 > https://issues.apache.org/jira/browse/HIVE-20164 > > > Repository: hive-git > > > Description > ------- > > Murmur Hash : Make sure CTAS and IAS use correct bucketing version > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties d08528f319 > ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java 1b433c7498 > ql/src/java/org/apache/hadoop/hive/ql/plan/TableDesc.java bbce940c2e > ql/src/test/queries/clientpositive/murmur_hash_migration.q PRE-CREATION > ql/src/test/results/clientpositive/llap/murmur_hash_migration.q.out > PRE-CREATION > > > Diff: https://reviews.apache.org/r/67974/diff/1/ > > > Testing > ------- > > > Thanks, > > Deepak Jaiswal > >
