----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68013/#review206338 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToString.java Lines 20-21 (patched) <https://reviews.apache.org/r/68013/#comment289273> Need to use slf4j. ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToString.java Lines 35 (patched) <https://reviews.apache.org/r/68013/#comment289275> Don't see a deleted file of earlier udf in patch. We shall delete that. ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToString.java Lines 53 (patched) <https://reviews.apache.org/r/68013/#comment289274> I guess there can be a string representation for map,array,struct. Wasn't earlier udf supporting it? If not, lets leave a TODO here. ql/src/test/results/clientpositive/char_pad_convert.q.out Line 133 (original), 133 (patched) <https://reviews.apache.org/r/68013/#comment289276> Lets add test for cast from dec to char/varchar as well. Both cases where size of char/varchar is bigger as well as smaller than decimal's scale. - Ashutosh Chauhan On July 23, 2018, 6:37 a.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68013/ > ----------------------------------------------------------- > > (Updated July 23, 2018, 6:37 a.m.) > > > Review request for hive, Ashutosh Chauhan and Sergey Shelukhin. > > > Bugs: HIVE-20082 > https://issues.apache.org/jira/browse/HIVE-20082 > > > Repository: hive-git > > > Description > ------- > > preserve decimal 0-padding during decimal-to-string conversion > > > Diffs > ----- > > > accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/predicate/TestAccumuloRangeGenerator.java > 9df2aadf75 > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 3d5506f85a > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java > 563134725a > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToString.java > a3a0e9d337 > ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java > 6a3f3b4ec9 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java > 0a9ab2b32f > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java > 40bd075ab7 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToString.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java > 4ed087e6be > ql/src/test/results/clientpositive/autoColumnStats_6.q.out 70788fde9f > ql/src/test/results/clientpositive/bucket_map_join_spark1.q.out 7764706665 > ql/src/test/results/clientpositive/bucket_map_join_spark2.q.out 090a0db125 > ql/src/test/results/clientpositive/bucket_map_join_spark3.q.out 692b8e7d9f > ql/src/test/results/clientpositive/bucketmapjoin5.q.out 79da3334b6 > ql/src/test/results/clientpositive/bucketmapjoin_negative.q.out 1a53c372cf > ql/src/test/results/clientpositive/bucketmapjoin_negative2.q.out 426b051ab0 > ql/src/test/results/clientpositive/bucketsortoptimize_insert_3.q.out > b798fa253d > ql/src/test/results/clientpositive/char_pad_convert.q.out b63dc25c99 > ql/src/test/results/clientpositive/column_pruner_multiple_children.q.out > 4b0aaab305 > ql/src/test/results/clientpositive/decimal_2.q.out 22f4c33dfe > ql/src/test/results/clientpositive/groupby12.q.out 7317c4e36f > ql/src/test/results/clientpositive/groupby5.q.out b3c2da2c46 > ql/src/test/results/clientpositive/groupby5_noskew.q.out 5307bc7f1a > ql/src/test/results/clientpositive/groupby7_map.q.out 5b4b9af0bf > ql/src/test/results/clientpositive/groupby7_map_multi_single_reducer.q.out > 00d26b9a47 > ql/src/test/results/clientpositive/groupby7_map_skew.q.out 089a14eb2e > ql/src/test/results/clientpositive/groupby7_noskew.q.out ec83bb6df9 > > ql/src/test/results/clientpositive/groupby7_noskew_multi_single_reducer.q.out > c844e51af2 > ql/src/test/results/clientpositive/groupby8.q.out 2d8ea6f8bc > ql/src/test/results/clientpositive/groupby8_map.q.out cf3ade654b > ql/src/test/results/clientpositive/groupby8_map_skew.q.out 86598aae72 > ql/src/test/results/clientpositive/groupby8_noskew.q.out a3d3656684 > ql/src/test/results/clientpositive/groupby9.q.out 8d97bdf5fb > ql/src/test/results/clientpositive/groupby_cube_multi_gby.q.out 5f08df6d5c > ql/src/test/results/clientpositive/groupby_position.q.out 5678bd5098 > ql/src/test/results/clientpositive/groupby_sort_1_23.q.out aaf89aeaa3 > ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out e8a1143890 > ql/src/test/results/clientpositive/infer_bucket_sort_dyn_part.q.out > fd9e5530e6 > > ql/src/test/results/clientpositive/infer_bucket_sort_grouping_operators.q.out > 50cc4dc00b > ql/src/test/results/clientpositive/infer_bucket_sort_map_operators.q.out > 254ac1498e > ql/src/test/results/clientpositive/infer_bucket_sort_num_buckets.q.out > f8445e61cb > ql/src/test/results/clientpositive/input_part10.q.out 4484cd0da2 > ql/src/test/results/clientpositive/llap/bucketmapjoin1.q.out e9c84b20cc > ql/src/test/results/clientpositive/llap/bucketmapjoin2.q.out 7532e74e7e > ql/src/test/results/clientpositive/llap/bucketmapjoin3.q.out 02169d86c2 > ql/src/test/results/clientpositive/llap/bucketmapjoin4.q.out 42b95cfa0a > ql/src/test/results/clientpositive/llap/default_constraint.q.out f93eb1fd1d > ql/src/test/results/clientpositive/llap/dynamic_partition_pruning.q.out > 1133b54985 > ql/src/test/results/clientpositive/llap/insert_into_default_keyword.q.out > 4c82e0977e > ql/src/test/results/clientpositive/llap/materialized_view_rewrite_6.q.out > 8a52138bfa > ql/src/test/results/clientpositive/llap/multi_insert_lateral_view.q.out > 74a694586c > ql/src/test/results/clientpositive/llap/orc_merge1.q.out 71899642c7 > ql/src/test/results/clientpositive/llap/orc_merge10.q.out 0f9bb2d0bd > ql/src/test/results/clientpositive/llap/orc_merge2.q.out b6e4dd69f0 > ql/src/test/results/clientpositive/llap/orc_merge_diff_fs.q.out 751bb4047c > ql/src/test/results/clientpositive/llap/rcfile_merge2.q.out afdc8f820b > ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part.q.out > ca2c9088a5 > > ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_all_complex.q.out > 4cb2ee8087 > > ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_all_complex_llap_io.q.out > 9248712549 > > ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_llap_io.q.out > fcbd8e8649 > ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part.q.out > fed044e0cc > > ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_all_complex.q.out > 5d6b08b319 > ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part.q.out > d71107d078 > > ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_all_complex.q.out > 5208183700 > ql/src/test/results/clientpositive/llap/stats11.q.out 8b59f722e6 > ql/src/test/results/clientpositive/llap/subquery_multi.q.out fb9cfd253d > ql/src/test/results/clientpositive/llap/tez_union_multiinsert.q.out > aa9d79033a > ql/src/test/results/clientpositive/llap/union6.q.out da9f4a21e6 > ql/src/test/results/clientpositive/llap/unionDistinct_1.q.out ff801321ad > ql/src/test/results/clientpositive/llap/unionDistinct_3.q.out d3f774d9c6 > ql/src/test/results/clientpositive/llap/vector_case_when_1.q.out ab083e78e0 > ql/src/test/results/clientpositive/llap/vector_char_mapjoin1.q.out > 7fe7af7f3b > ql/src/test/results/clientpositive/llap/vector_decimal_1.q.out 8d8cbf5115 > ql/src/test/results/clientpositive/llap/vector_decimal_2.q.out 8cd753cb90 > ql/src/test/results/clientpositive/llap/vector_decimal_expressions.q.out > 190bcd584f > ql/src/test/results/clientpositive/llap/vector_string_concat.q.out > c6b3dcc80c > ql/src/test/results/clientpositive/llap/vector_udf1.q.out aef23fd3b1 > ql/src/test/results/clientpositive/llap/vector_varchar_mapjoin1.q.out > 7270d75781 > ql/src/test/results/clientpositive/llap/vectorized_casts.q.out 8fecb022fa > > ql/src/test/results/clientpositive/llap/vectorized_dynamic_partition_pruning.q.out > 8ee96d3367 > ql/src/test/results/clientpositive/multi_insert_mixed.q.out e9729a4ace > ql/src/test/results/clientpositive/orc_merge1.q.out 622e899155 > ql/src/test/results/clientpositive/orc_merge10.q.out b54abfa708 > ql/src/test/results/clientpositive/orc_merge2.q.out 2f48619925 > ql/src/test/results/clientpositive/orc_merge_diff_fs.q.out 2b4aec3cdc > ql/src/test/results/clientpositive/perf/spark/query36.q.out bdf96a9f35 > ql/src/test/results/clientpositive/perf/spark/query70.q.out 2f94f947bb > ql/src/test/results/clientpositive/perf/spark/query86.q.out ff7ca830b4 > ql/src/test/results/clientpositive/perf/tez/query36.q.out 53c53db7a1 > ql/src/test/results/clientpositive/perf/tez/query70.q.out f21c7ad50e > ql/src/test/results/clientpositive/perf/tez/query86.q.out 1c8d228ba9 > ql/src/test/results/clientpositive/show_functions.q.out 629781a456 > ql/src/test/results/clientpositive/smb_mapjoin_20.q.out cfe1e02bf9 > ql/src/test/results/clientpositive/spark/bucket_map_join_spark1.q.out > 2a69ba067b > ql/src/test/results/clientpositive/spark/bucket_map_join_spark2.q.out > 7fecee2f0d > ql/src/test/results/clientpositive/spark/bucket_map_join_spark3.q.out > 75aaffa6dc > ql/src/test/results/clientpositive/spark/bucketmapjoin1.q.out cf7503e0a2 > ql/src/test/results/clientpositive/spark/bucketmapjoin2.q.out d23fe499ee > ql/src/test/results/clientpositive/spark/bucketmapjoin3.q.out 8c33dbf210 > ql/src/test/results/clientpositive/spark/bucketmapjoin4.q.out 287bde6ca4 > ql/src/test/results/clientpositive/spark/bucketmapjoin5.q.out 3f17e4e5b1 > ql/src/test/results/clientpositive/spark/bucketmapjoin_negative.q.out > cade09f8d6 > ql/src/test/results/clientpositive/spark/bucketmapjoin_negative2.q.out > a4e2bef9b6 > ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out 5124d95ee7 > ql/src/test/results/clientpositive/spark/groupby5.q.out 6f640cf0b7 > ql/src/test/results/clientpositive/spark/groupby5_noskew.q.out 5f3678e9b2 > ql/src/test/results/clientpositive/spark/groupby7_map.q.out d5ea3ec49a > > ql/src/test/results/clientpositive/spark/groupby7_map_multi_single_reducer.q.out > 9d09491a46 > ql/src/test/results/clientpositive/spark/groupby7_map_skew.q.out 5868f7abf9 > ql/src/test/results/clientpositive/spark/groupby7_noskew.q.out 53345aac9e > > ql/src/test/results/clientpositive/spark/groupby7_noskew_multi_single_reducer.q.out > 68809005e1 > ql/src/test/results/clientpositive/spark/groupby8.q.out c6cac1bf80 > ql/src/test/results/clientpositive/spark/groupby8_map.q.out 40d3e7c103 > ql/src/test/results/clientpositive/spark/groupby8_map_skew.q.out 053c717d09 > ql/src/test/results/clientpositive/spark/groupby8_noskew.q.out 2ef72b7c18 > ql/src/test/results/clientpositive/spark/groupby9.q.out 316f936db3 > ql/src/test/results/clientpositive/spark/groupby_position.q.out 7bb5f18e41 > ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 873717273d > ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out > 571203089d > > ql/src/test/results/clientpositive/spark/infer_bucket_sort_map_operators.q.out > 268dd10450 > ql/src/test/results/clientpositive/spark/multi_insert_lateral_view.q.out > 22fe91cb2b > ql/src/test/results/clientpositive/spark/multi_insert_mixed.q.out > 0dde265f8d > ql/src/test/results/clientpositive/spark/smb_mapjoin_20.q.out fd0f1c0b26 > > ql/src/test/results/clientpositive/spark/spark_dynamic_partition_pruning.q.out > cecee578db > > ql/src/test/results/clientpositive/spark/spark_vectorized_dynamic_partition_pruning.q.out > c41dba93ee > ql/src/test/results/clientpositive/spark/stats1.q.out b755b4cc3a > ql/src/test/results/clientpositive/spark/subquery_multi.q.out f90b353818 > ql/src/test/results/clientpositive/spark/union17.q.out 93086a03fe > ql/src/test/results/clientpositive/spark/union18.q.out 4b6c32daa7 > ql/src/test/results/clientpositive/spark/union19.q.out 6d47270aee > ql/src/test/results/clientpositive/spark/union20.q.out b9674089fe > ql/src/test/results/clientpositive/spark/union32.q.out 925392b500 > ql/src/test/results/clientpositive/spark/union33.q.out 190b6c0128 > ql/src/test/results/clientpositive/spark/union6.q.out fca52a3dda > ql/src/test/results/clientpositive/spark/union_remove_19.q.out bf8abf1b42 > ql/src/test/results/clientpositive/spark/vector_string_concat.q.out > cee7995a99 > ql/src/test/results/clientpositive/stats1.q.out 10291ce4b5 > ql/src/test/results/clientpositive/tablevalues.q.out 74fda005d5 > ql/src/test/results/clientpositive/udf3.q.out 0f7c859db8 > ql/src/test/results/clientpositive/udf_string.q.out 71b9b293df > ql/src/test/results/clientpositive/union17.q.out b7748c0270 > ql/src/test/results/clientpositive/union18.q.out 109fa8d4ff > ql/src/test/results/clientpositive/union19.q.out f57d8fb4f9 > ql/src/test/results/clientpositive/union20.q.out 6cc5eff503 > ql/src/test/results/clientpositive/union32.q.out 92ed7d1d19 > ql/src/test/results/clientpositive/union33.q.out 1b8b35b9c6 > ql/src/test/results/clientpositive/union6.q.out 37c75214c3 > ql/src/test/results/clientpositive/union_remove_19.q.out 0c67e67ca5 > ql/src/test/results/clientpositive/vector_case_when_1.q.out 59d813371d > ql/src/test/results/clientpositive/vector_char_mapjoin1.q.out 73012578b8 > ql/src/test/results/clientpositive/vector_decimal_1.q.out e61691273c > ql/src/test/results/clientpositive/vector_decimal_expressions.q.out > 0193f3bc88 > ql/src/test/results/clientpositive/vector_string_concat.q.out 68b011d2e5 > ql/src/test/results/clientpositive/vector_varchar_mapjoin1.q.out f956d58c5f > ql/src/test/results/clientpositive/vectorized_casts.q.out a19b5ee67a > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java > 1e12ccaf3e > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java > 6362f2ef57 > > serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestObjectInspectorConverters.java > 32fab314a5 > > serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/primitive/TestPrimitiveObjectInspectorUtils.java > 3c2797e979 > > > Diff: https://reviews.apache.org/r/68013/diff/1/ > > > Testing > ------- > > > Thanks, > > Jason Dere > >
