----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68011/#review206425 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java Line 4070 (original), 4070 (patched) <https://reviews.apache.org/r/68011/#comment289377> Looks like there is no need to duplicate() This RR can be used as is. ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java Line 4844 (original), 4836-4838 (patched) <https://reviews.apache.org/r/68011/#comment289378> This comment is better placed as comments for method params in genLogicalPlan() ql/src/test/results/clientnegative/create_view_failure5.q.out Line 1 (original), 1 (patched) <https://reviews.apache.org/r/68011/#comment289372> Why is clientnegative/ambiguous_col.q test removed? ql/src/test/results/clientpositive/bucketsortoptimize_insert_4.q.out Lines 84-85 (patched) <https://reviews.apache.org/r/68011/#comment289374> This extra operator will result in perf loss. We do have an optimization rule to remove identity projects. Is that not able to optimize this select now? ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out Line 3732 (original), 3729 (patched) <https://reviews.apache.org/r/68011/#comment289375> Now we are shuffling an extra constant column between vertices. This will result in perf loss. ql/src/test/results/clientpositive/llap/vector_windowing.q.out Lines 210 (patched) <https://reviews.apache.org/r/68011/#comment289376> Seems like RSDeDup optimization failed to merge 2 RSs in this case. - Ashutosh Chauhan On July 23, 2018, 1:43 a.m., Vineet Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68011/ > ----------------------------------------------------------- > > (Updated July 23, 2018, 1:43 a.m.) > > > Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez. > > > Bugs: HIVE-19770 > https://issues.apache.org/jira/browse/HIVE-19770 > > > Repository: hive-git > > > Description > ------- > > See Jira > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java f008c4dfae > ql/src/test/queries/clientnegative/ambiguous_col.q e8f2c8d750 > ql/src/test/results/clientnegative/ambiguous_col.q.out a2915a4a5d > ql/src/test/results/clientnegative/create_view_failure5.q.out d79dc64a30 > ql/src/test/results/clientpositive/bucketsortoptimize_insert_4.q.out > 6c45fcb7ac > ql/src/test/results/clientpositive/char_udf1.q.out 69d76d7269 > ql/src/test/results/clientpositive/keyword_2.q.out f1d63b6e5f > ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out > 5e766c8982 > ql/src/test/results/clientpositive/llap/explainanalyze_2.q.out ab86821f07 > ql/src/test/results/clientpositive/llap/explainuser_2.q.out 5f5f5f6015 > ql/src/test/results/clientpositive/llap/limit_join_transpose.q.out > ebaac18127 > ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part.q.out > 97752f3c25 > > ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_llap_io.q.out > 23c33a3141 > > ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_update.q.out > eeabb8cc61 > > ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_update_llap_io.q.out > f15a144a96 > ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table.q.out > a043b679ae > > ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table_llap_io.q.out > 35c1fae6d0 > > ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table_update.q.out > 730d3d2312 > > ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table_update_llap_io.q.out > 95bfa2507d > > ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_part_llap_io.q.out > 7e1cce3f4f > > ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_part_update.q.out > 242b95e603 > > ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_part_update_llap_io.q.out > 53cb8fc8c4 > ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table.q.out > 219ad7a82e > > ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table_llap_io.q.out > ce9fe84d1e > > ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table_update.q.out > f8df92faf7 > > ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table_update_llap_io.q.out > 2292dcb24b > ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part.q.out > e02a1e247d > > ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part_all_primitive.q.out > f70efd6f94 > > ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part_all_primitive_llap_io.q.out > 351d201700 > > ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part_llap_io.q.out > 603c669f51 > ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_table.q.out > 454bf264d3 > > ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_table_llap_io.q.out > 7ccda3dc91 > ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part.q.out > e5aa7f418a > > ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part_all_primitive.q.out > ae483ca2b0 > > ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part_all_primitive_llap_io.q.out > fb1a4d2d33 > ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_table.q.out > ff23f05007 > > ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_table_llap_io.q.out > 97c8730c11 > ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part.q.out > ca2c9088a5 > > ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_all_primitive.q.out > 29054b1e6e > > ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_all_primitive_llap_io.q.out > 003457bf14 > > ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_llap_io.q.out > fcbd8e8649 > ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_table.q.out > 17ee442da0 > > ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_table_llap_io.q.out > 5aba880938 > ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part.q.out > fed044e0cc > > ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_all_primitive.q.out > 5c496953ac > > ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_all_primitive_llap_io.q.out > eceff3bf66 > > ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_llap_io.q.out > 36b53e5ec2 > ql/src/test/results/clientpositive/llap/schema_evol_text_vec_table.q.out > ed7a0b6cc4 > > ql/src/test/results/clientpositive/llap/schema_evol_text_vec_table_llap_io.q.out > 867e13406b > ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part.q.out > d71107d078 > > ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_all_primitive.q.out > 9d32b03dcd > > ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_all_primitive_llap_io.q.out > 9a9f41e0c2 > > ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_llap_io.q.out > 97a964fc60 > ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_table.q.out > a2c26b20a6 > > ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_table_llap_io.q.out > 2c25fefee6 > ql/src/test/results/clientpositive/llap/varchar_udf1.q.out fe20d54586 > ql/src/test/results/clientpositive/llap/vector_adaptor_usage_mode.q.out > 1846354456 > ql/src/test/results/clientpositive/llap/vector_case_when_2.q.out 966f6c5a8e > ql/src/test/results/clientpositive/llap/vector_interval_arithmetic.q.out > 2fadf29eee > ql/src/test/results/clientpositive/llap/vector_udf1.q.out aef23fd3b1 > ql/src/test/results/clientpositive/llap/vector_udf2.q.out a33c6bef44 > ql/src/test/results/clientpositive/llap/vector_windowing.q.out 2d49bca53b > ql/src/test/results/clientpositive/mm_buckets.q.out d37e2f6a54 > ql/src/test/results/clientpositive/smb_mapjoin_20.q.out cfe1e02bf9 > ql/src/test/results/clientpositive/spark/bucketsortoptimize_insert_4.q.out > b5daffb9cf > ql/src/test/results/clientpositive/spark/union_remove_22.q.out 90861a3adb > ql/src/test/results/clientpositive/udf_reflect2.q.out f3bbff24d6 > ql/src/test/results/clientpositive/union37.q.out 1b9ac10c0d > ql/src/test/results/clientpositive/union_remove_22.q.out 247db091ee > ql/src/test/results/clientpositive/vector_case_when_2.q.out 9ff87502af > ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out > ee7602aa7a > > > Diff: https://reviews.apache.org/r/68011/diff/1/ > > > Testing > ------- > > > Thanks, > > Vineet Garg > >
