[
https://issues.apache.org/jira/browse/HIVE-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170424#comment-13170424
]
jirapos...@reviews.apache.org commented on HIVE-2503:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2820/#review3926
-----------------------------------------------------------
We should include a test case for regression purposes. You can achieve this by
playing with test.service.standalone.server. If that doesn't work out, then you
can always extend TestHiveServer and setup the test the way you want.
- Ashutosh
On 2011-11-14 08:54:00, Navis Ryu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2820/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-14 08:54:00)
bq.
bq.
bq. Review request for hive and Carl Steinbach.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. We uses multiple HiveClient connected to single HiveServer. After
configuring connections, we've found the environment variables are different
from expected.
bq. Current hive server uses single instance of HiveConf and this seemed to
make the problem.
bq.
bq.
bq. This addresses bug HIVE-2503.
bq. https://issues.apache.org/jira/browse/HIVE-2503
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. service/src/java/org/apache/hadoop/hive/service/HiveServer.java a2d599f
bq.
bq. Diff: https://reviews.apache.org/r/2820/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. If we use 'standAloneServer' in TestHiveServer.class, it is very simple to
make the test case. But it seemed to be 'false' which makes it more complex.
bq.
bq.
bq. Thanks,
bq.
bq. Navis
bq.
bq.
> HiveServer should provide per session configuration
> ---------------------------------------------------
>
> Key: HIVE-2503
> URL: https://issues.apache.org/jira/browse/HIVE-2503
> Project: Hive
> Issue Type: Bug
> Components: CLI, Server Infrastructure
> Affects Versions: 0.9.0
> Reporter: Navis
> Assignee: Navis
> Fix For: 0.9.0
>
> Attachments: HIVE-2503.1.patch.txt
>
>
> Currently ThriftHiveProcessorFactory returns same HiveConf instance to
> HiveServerHandler, making impossible to use per sesssion configuration. Just
> wrapping 'conf' -> 'new HiveConf(conf)' seemed to solve this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
