----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68115/#review206627 -----------------------------------------------------------
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java Lines 76 (patched) <https://reviews.apache.org/r/68115/#comment289673> The type -> ObjectInspector is the only one which I think looks like it is there for "intern-ing" of object inpsectors (So that object == can be used instead of a deep equals check). Of course, I'm not sure that's a "real" problem unless a query takes > 5 minutes to compile. If that doesn't show up in the leaks, it might better to leave that one alone. - Gopal V On July 31, 2018, 12:08 a.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68115/ > ----------------------------------------------------------- > > (Updated July 31, 2018, 12:08 a.m.) > > > Review request for hive, Gopal V and Sergey Shelukhin. > > > Bugs: HIVE-20274 > https://issues.apache.org/jira/browse/HIVE-20274 > > > Repository: hive-git > > > Description > ------- > > HIVE-20274: HiveServer2 ObjectInspectorFactory leaks for Struct and List > object inspectors > > > Diffs > ----- > > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java > b45a9dee72f5fb3a139ee205a05e23c068b1fa0c > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ReflectionStructObjectInspector.java > 3a88a400250afa0e29001ec118e006f937678089 > > serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestReflectionObjectInspectors.java > cb1440e98b8fad399c4c02a7440d2a30483455f4 > > > Diff: https://reviews.apache.org/r/68115/diff/1/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >
