> On July 30, 2018, 6:11 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/cbo_simple_select.q.out > > Line 866 (original), 866 (patched) > > <https://reviews.apache.org/r/68108/diff/1/?file=2065277#file2065277line866> > > > > This didnt get rewritten into IN. Is that expected?
no, this is a different class of comparision; because there are columns on both sides ; I think this way the extraction logic is kinda confused... note: calcite may handle `x=x` to `true` or `x is not null` simplification. > On July 30, 2018, 6:11 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/druid_basic3.q.out > > Line 280 (original), 280 (patched) > > <https://reviews.apache.org/r/68108/diff/1/?file=2065278#file2065278line280> > > > > No folding of OR into IN ? for druid also, IN is more performant. actually this is a case of: `UDF(x) IN (c1,c2)` and it's not getting refolded because of the udf... probably later could be done; but for opening INs only those are considered which have a column on the left side. > On July 30, 2018, 6:11 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/llap/vectorized_case.q.out > > Line 54 (original), 54 (patched) > > <https://reviews.apache.org/r/68108/diff/1/?file=2065299#file2065299line54> > > > > yeah.. i think thats because now constants are of type integer. Note in > > OR clause they had S suffix which made them smallint. > > > > This used to happen because of > > https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java#L1157 > > > > This is during parsing of expresions. We need to enhance this logic now > > for INs as well. updated the logic in typecheckprocfactory > On July 30, 2018, 6:11 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/perf/tez/query15.q.out > > Line 74 (original), 74 (patched) > > <https://reviews.apache.org/r/68108/diff/1/?file=2065316#file2065316line74> > > > > No folding back to IN ? new patch will not `open` INs like this... but that's still not enough to refold: `_col3 IN ('CA','WA','GA')`; some work needs to be HIVE-20296 > On July 30, 2018, 6:11 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/perf/tez/query45.q.out > > Line 81 (original), 81 (patched) > > <https://reviews.apache.org/r/68108/diff/1/?file=2065318#file2065318line81> > > > > No folding back to IN? fixed in new patch > On July 30, 2018, 6:11 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/perf/tez/query63.q.out > > Line 135 (original), 135 (patched) > > <https://reviews.apache.org/r/68108/diff/1/?file=2065321#file2065321line135> > > > > No folding back to IN ? this needed a little tweak in hivepointlookupoptimizer; now it notices some redundancies in this condition! :) > On July 30, 2018, 6:11 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/perf/tez/query8.q.out > > Line 337 (original), 337 (patched) > > <https://reviews.apache.org/r/68108/diff/1/?file=2065324#file2065324line337> > > > > No folding back to IN ? this is not expanded anymore...since it can't be closed back right now; rule is to only open if left side is a column. > On July 30, 2018, 6:11 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/vector_non_constant_in_expr.q.out > > Line 22 (original), 22 (patched) > > <https://reviews.apache.org/r/68108/diff/1/?file=2065343#file2065343line22> > > > > these ORs didnt get folded in IN, expected? there are columns on both sides - probably later will be taken care of... - Zoltan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68108/#review206603 ----------------------------------------------------------- On Aug. 2, 2018, 11:13 a.m., Zoltan Haindrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68108/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2018, 11:13 a.m.) > > > Review request for hive, Ashutosh Chauhan and Gopal V. > > > Bugs: HIVE-19097 > https://issues.apache.org/jira/browse/HIVE-19097 > > > Repository: hive-git > > > Description > ------- > > * open in to or - only column can be on left side > * close ors into in at 2 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 093b4a73f3 > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java > 97e405970f > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java > f544f58632 > ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java > fa941a1b25 > ql/src/test/org/apache/hadoop/hive/ql/plan/mapping/TestCounterMapping.java > b57b5ddc2c > ql/src/test/queries/clientpositive/pointlookup.q 1b65cec71c > ql/src/test/queries/clientpositive/pointlookup2.q fe19381368 > ql/src/test/queries/clientpositive/pointlookup3.q f98feeb164 > ql/src/test/queries/clientpositive/stat_estimate_related_col.q 52da2f759a > ql/src/test/results/clientpositive/alter_partition_coltype.q.out 5d033a3c01 > ql/src/test/results/clientpositive/annotate_stats_filter.q.out 54395886d2 > ql/src/test/results/clientpositive/annotate_stats_part.q.out bafc6de51e > ql/src/test/results/clientpositive/auto_join19.q.out 3e07ec06de > ql/src/test/results/clientpositive/cbo_rp_simple_select.q.out 2e7d79660b > ql/src/test/results/clientpositive/cbo_simple_select.q.out 33f0e71080 > ql/src/test/results/clientpositive/druid_intervals.q.out a5203c3182 > ql/src/test/results/clientpositive/dynamic_partition_skip_default.q.out > 97922c2636 > ql/src/test/results/clientpositive/filter_cond_pushdown.q.out b84a2d4b79 > ql/src/test/results/clientpositive/fold_eq_with_case_when.q.out d06fb60345 > ql/src/test/results/clientpositive/list_bucket_query_multiskew_2.q.out > 98ad3656e7 > ql/src/test/results/clientpositive/llap/bucketpruning1.q.out cc637db05b > ql/src/test/results/clientpositive/llap/bucketsortoptimize_insert_7.q.out > c7f5b887b6 > ql/src/test/results/clientpositive/llap/cbo_simple_select.q.out a35edb42a8 > ql/src/test/results/clientpositive/llap/check_constraint.q.out 123a3e46fc > ql/src/test/results/clientpositive/llap/dynamic_partition_pruning.q.out > 8f06ee58ce > ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out > e03cd3437e > ql/src/test/results/clientpositive/llap/explainuser_1.q.out 708fa17617 > ql/src/test/results/clientpositive/llap/kryo.q.out 234bae89c7 > ql/src/test/results/clientpositive/llap/llap_decimal64_reader.q.out > 88ddd9c076 > ql/src/test/results/clientpositive/llap/materialized_view_rewrite_ssb.q.out > 1841f1f4d3 > > ql/src/test/results/clientpositive/llap/materialized_view_rewrite_ssb_2.q.out > d7c92d8c59 > ql/src/test/results/clientpositive/llap/orc_llap_counters.q.out 65eec521a2 > ql/src/test/results/clientpositive/llap/vector_between_in.q.out 801dda315a > ql/src/test/results/clientpositive/llap/vector_string_decimal.q.out > 54d9914caa > > ql/src/test/results/clientpositive/llap/vector_windowing_multipartitioning.q.out > 725ed34acb > ql/src/test/results/clientpositive/llap/vector_windowing_navfn.q.out > 74ac56d1c6 > ql/src/test/results/clientpositive/llap/vectorized_case.q.out d444ae86a1 > > ql/src/test/results/clientpositive/llap/vectorized_dynamic_partition_pruning.q.out > ba004e9716 > ql/src/test/results/clientpositive/pcr.q.out 919b71234d > ql/src/test/results/clientpositive/perf/spark/query13.q.out fb2a061c63 > ql/src/test/results/clientpositive/perf/spark/query15.q.out 3d6fbdac77 > ql/src/test/results/clientpositive/perf/spark/query34.q.out b40081e4f0 > ql/src/test/results/clientpositive/perf/spark/query48.q.out 60a4767a14 > ql/src/test/results/clientpositive/perf/spark/query53.q.out 2b1cdfea98 > ql/src/test/results/clientpositive/perf/spark/query63.q.out b506455dbf > ql/src/test/results/clientpositive/perf/spark/query71.q.out bf9c06debf > ql/src/test/results/clientpositive/perf/spark/query73.q.out 20ec874e88 > ql/src/test/results/clientpositive/perf/spark/query85.q.out 572ba54f78 > ql/src/test/results/clientpositive/perf/spark/query89.q.out 1acc577669 > ql/src/test/results/clientpositive/perf/spark/query91.q.out de8977da51 > ql/src/test/results/clientpositive/perf/tez/query13.q.out 5cd4e27de3 > ql/src/test/results/clientpositive/perf/tez/query15.q.out 3c7ae664b1 > ql/src/test/results/clientpositive/perf/tez/query34.q.out 9b7b482d3b > ql/src/test/results/clientpositive/perf/tez/query48.q.out 1cf8d5c0da > ql/src/test/results/clientpositive/perf/tez/query53.q.out 3567534ac4 > ql/src/test/results/clientpositive/perf/tez/query63.q.out a5b7b5a788 > ql/src/test/results/clientpositive/perf/tez/query71.q.out 4521aabc9f > ql/src/test/results/clientpositive/perf/tez/query73.q.out cfa5213b5e > ql/src/test/results/clientpositive/perf/tez/query85.q.out 4e42d69735 > ql/src/test/results/clientpositive/perf/tez/query89.q.out ee3374ea5c > ql/src/test/results/clientpositive/perf/tez/query91.q.out a53c7d796d > ql/src/test/results/clientpositive/ppd_transform.q.out b38088f16a > ql/src/test/results/clientpositive/remove_exprs_stats.q.out a9c0051371 > ql/src/test/results/clientpositive/spark/auto_join19.q.out d7d8caee33 > ql/src/test/results/clientpositive/spark/bucketsortoptimize_insert_7.q.out > e07904ac44 > ql/src/test/results/clientpositive/spark/cbo_simple_select.q.out a35edb42a8 > ql/src/test/results/clientpositive/spark/pcr.q.out 83437e5593 > ql/src/test/results/clientpositive/spark/ppd_transform.q.out 4dfc0fed6e > > ql/src/test/results/clientpositive/spark/spark_dynamic_partition_pruning.q.out > 24202522f5 > ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out > c5d0d63f8c > ql/src/test/results/clientpositive/spark/vector_between_in.q.out 8b1a2be89b > ql/src/test/results/clientpositive/spark/vectorized_case.q.out 0bf2a4bfa5 > ql/src/test/results/clientpositive/stat_estimate_related_col.q.out > 669adafda3 > ql/src/test/results/clientpositive/tez/explainanalyze_5.q.out 5a50431d26 > ql/src/test/results/clientpositive/vector_non_constant_in_expr.q.out > 966edad025 > ql/src/test/results/clientpositive/vectorized_case.q.out 828131f8c6 > > > Diff: https://reviews.apache.org/r/68108/diff/2/ > > > Testing > ------- > > > Thanks, > > Zoltan Haindrich > >
