----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61663/#review208622 -----------------------------------------------------------
Fix it then ship it! Thanks for the revitalization of this change! ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java Line 508 (original), 509 (patched) <https://reviews.apache.org/r/61663/#comment292721> Might want to use LOG.error(String, Throwable) common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Lines 3099 (patched) <https://reviews.apache.org/r/61663/#comment292719> After committing the change, please do not forget to update the configuration Wiki. :) - Peter Vary On szept. 7, 2018, 3:24 du, Karen Coppage wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61663/ > ----------------------------------------------------------- > > (Updated szept. 7, 2018, 3:24 du) > > > Review request for hive, Peter Vary and Xuefu Zhang. > > > Bugs: HIVE-17300 > https://issues.apache.org/jira/browse/HIVE-17300 > > > Repository: hive-git > > > Description > ------- > > I’m working on a feature of the Hive WebUI Query Plan tab that would provide > the option to display the query plan as a nice graph (scroll down for > screenshots). If you click on one of the graph’s stages, the plan for that > stage appears as text below. > Stages are color-coded if they have a status (Success, Error, Running), and > the rest are grayed out. Coloring is based on status already available in the > WebUI, under the Stages tab. > There is an additional option to display stats for MapReduce tasks. This > includes the job’s ID, tracking URL (where the logs are found), and mapper > and reducer numbers/progress, among other info. > The library I’m using for the graph is called vis.js (http://visjs.org/). It > has an Apache license, and the only necessary file to be included from this > library is about 700 KB. > I tried to keep server-side changes minimal, and graph generation is taken > care of by the client. Plans with more than a given number of stages > (default: 25) won't be displayed in order to preserve resources. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/LogUtils.java 5068eb5be7 > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 40ea3ac0c5 > > itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestQueryDisplay.java > 95b46a8149 > ql/src/java/org/apache/hadoop/hive/ql/Driver.java dad2035362 > ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java ac45ec46de > ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java 9a77c2969e > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java > eb6cbf71e2 > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java a71faf8576 > service/src/jamon/org/apache/hive/tmpl/QueryProfileTmpl.jamon f04d655440 > service/src/resources/hive-webapps/static/css/query-plan-graph.css > PRE-CREATION > service/src/resources/hive-webapps/static/js/query-plan-graph.js > PRE-CREATION > service/src/resources/hive-webapps/static/js/vis.min.js PRE-CREATION > > > Diff: https://reviews.apache.org/r/61663/diff/5/ > > > Testing > ------- > > > File Attachments > ---------------- > > HIVE-17300.7.patch > > https://reviews.apache.org/media/uploaded/files/2018/09/07/e8ada965-ea33-48a2-a0b1-e56e8185c4fa__HIVE-17300.7.patch > > > Thanks, > > Karen Coppage > >
