----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68767/#review208821 -----------------------------------------------------------
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java Line 316 (original), 315 (patched) <https://reviews.apache.org/r/68767/#comment293035> may be neater to use 'for (String param: params)' or whatever the syntax is standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java Lines 316 (patched) <https://reviews.apache.org/r/68767/#comment293033> 1) Does setObject() work OK on all the jdbc drivers that are supported? In the oast I have seen cases where it was necessary to dispatch to the correct method like setString, setInt 2) can the params over be null? Do we need to call setNull instead of setObject()? Again we need to consider all the drivers. standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java Line 317 (original), 320 (patched) <https://reviews.apache.org/r/68767/#comment293034> I note the tracing will be less intersting now. Do we now need to insert the paramters as well? - Andrew Sherman On Sept. 19, 2018, 9:46 a.m., Laszlo Pinter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68767/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2018, 9:46 a.m.) > > > Review request for hive, Alexander Kolbasov, Peter Vary, and Vihang > Karajgaonkar. > > > Repository: hive-git > > > Description > ------- > > HIVE-20551: Create PreparedStatement query dynamically when IN clause is used > > > Diffs > ----- > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 571c789eddfd2b1a27c65c48bdc6dccfafaaf676 > > > Diff: https://reviews.apache.org/r/68767/diff/1/ > > > Testing > ------- > > > Thanks, > > Laszlo Pinter > >
