> On Sept. 24, 2018, 6:54 p.m., Eugene Koifman wrote: > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTxns.java > > Lines 101 (patched) > > <https://reviews.apache.org/r/68805/diff/1/?file=2091070#file2091070line101> > > > > Nit: what is the advantage of using direct jdbc calls to modify the > > metastore DBMS. Why not run "cretate table ...", "Alter table..." though > > Driver and "describe table to see the value"
The problem I have with using the driver is that I'd have to add the dependency hive-exec. - Jaume ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68805/#review208955 ----------------------------------------------------------- On Sept. 21, 2018, 10:51 p.m., Jaume Marhuenda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68805/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2018, 10:51 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-20538: Allow to store a key value together with a transaction. > > > Diffs > ----- > > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/CommitTxnRequest.java > db47f9db8b > > standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php > 22deffe1d3 > > standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py > 38fac465d7 > > standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb > 0192c6da31 > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > df6d56b679 > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 54e7eda0da > standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift > 85a5c601e0 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > d76049eda1 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java > ce590d0f55 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTxns.java > db4dd9ec42 > > > Diff: https://reviews.apache.org/r/68805/diff/1/ > > > Testing > ------- > > > Thanks, > > Jaume Marhuenda > >
