----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/#review209081 -----------------------------------------------------------
Thanks Denys, I like this new version. My last comments are below. What do you think is it worth to create a new version of the patch? Thanks, Peter ql/src/java/org/apache/hadoop/hive/ql/lock/CompileLock.java Lines 44 (patched) <https://reviews.apache.org/r/68683/#comment293339> Would it be a good idea to remove the public constructor? We are using factory to create CompileLock, so we might want to emphasize that ql/src/java/org/apache/hadoop/hive/ql/lock/CompileLock.java Lines 64 (patched) <https://reviews.apache.org/r/68683/#comment293340> We do not use this anywhere - we might want to consider to remove this altogether and keep only the one without parameters? ql/src/java/org/apache/hadoop/hive/ql/lock/CompileLock.java Lines 110 (patched) <https://reviews.apache.org/r/68683/#comment293341> Can this cause problems if called after a failed tryAcquire? Since this method is not used anywhere outside this class, it might be a good idea to merge with close. - Peter Vary On szept. 26, 2018, 1:08 du, denys kuzmenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68683/ > ----------------------------------------------------------- > > (Updated szept. 26, 2018, 1:08 du) > > > Review request for hive, Zoltan Haindrich, Zoltan Haindrich, Naveen Gangam, > and Peter Vary. > > > Bugs: HIVE-20535 > https://issues.apache.org/jira/browse/HIVE-20535 > > > Repository: hive-git > > > Description > ------- > > When removing the compile lock, it is quite risky to remove it entirely. > > It would be good to provide a pool size for the concurrent compilation, so > the administrator can limit the load > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8c39de3e77 > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 737debd2ad > ql/src/java/org/apache/hadoop/hive/ql/lock/CompileLock.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/lock/CompileLockFactory.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/CompileLockTest.java PRE-CREATION > > > Diff: https://reviews.apache.org/r/68683/diff/7/ > > > Testing > ------- > > Added CompileLockTest > > > File Attachments > ---------------- > > HIVE-20535.1.patch > > https://reviews.apache.org/media/uploaded/files/2018/09/13/41f5a84a-70e5-4882-99c1-1cf98c4364e4__HIVE-20535.1.patch > HIVE-20535.14.patch > > https://reviews.apache.org/media/uploaded/files/2018/09/25/335b0f4b-ea94-41d4-881a-ec8bb870a376__HIVE-20535.14.patch > HIVE-20535.14.patch > > https://reviews.apache.org/media/uploaded/files/2018/09/25/a92b6da2-eeba-46ee-9409-162653826172__HIVE-20535.14.patch > HIVE-20535.14.patch > > https://reviews.apache.org/media/uploaded/files/2018/09/25/9db4cf76-9188-48fb-bd3d-5b28e43a791b__HIVE-20535.14.patch > > > Thanks, > > denys kuzmenko > >
