> On Oct. 3, 2018, 12:33 a.m., Andrew Sherman wrote: > > All looks good, just a few nits which I noticed
Unfortunately, I cannot update this review board URL since its owned by Alexander. Latest patch on the JIRA has the suggested changes. Will see if I can update the diffs here somehow. > On Oct. 3, 2018, 12:33 a.m., Andrew Sherman wrote: > > standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift > > Line 1667 (original), 1667 (patched) > > <https://reviews.apache.org/r/68664/diff/2-3/?file=2088329#file2088329line1667> > > > > I think he previous text 'E.g.' is better done > On Oct. 3, 2018, 12:33 a.m., Andrew Sherman wrote: > > standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift > > Line 1673 (original), 1673 (patched) > > <https://reviews.apache.org/r/68664/diff/2-3/?file=2088329#file2088329line1673> > > > > Not sure why this changed, should be 'compliant' done > On Oct. 3, 2018, 12:33 a.m., Andrew Sherman wrote: > > standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift > > Line 1676 (original), 1676 (patched) > > <https://reviews.apache.org/r/68664/diff/2-3/?file=2088329#file2088329line1676> > > > > Not sure why this changed, should be 'compliant' done > On Oct. 3, 2018, 12:33 a.m., Andrew Sherman wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > > Lines 3765 (patched) > > <https://reviews.apache.org/r/68664/diff/3/?file=2093890#file2093890line3765> > > > > Arguably clearer to say "providing different ways of filtering and > > controlling output" changed - Vihang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68664/#review209171 ----------------------------------------------------------- On Oct. 3, 2018, 12:07 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68664/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2018, 12:07 a.m.) > > > Review request for hive, Aihua Xu, Andrew Sherman, Peter Vary, Todd Lipcon, > and Vihang Karajgaonkar. > > > Bugs: HIVE-20306 > https://issues.apache.org/jira/browse/HIVE-20306 > > > Repository: hive-git > > > Description > ------- > > HIVE-20306: Implement projection spec for fetching only requested fields from > partitions > > > Diffs > ----- > > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java > 0ad2a2469e0330e050fdb8983078b80617afbbf1 > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsFilterSpec.java > PRE-CREATION > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsProjectSpec.java > PRE-CREATION > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsRequest.java > PRE-CREATION > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java > PRE-CREATION > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionFilterMode.java > PRE-CREATION > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java > ae0956870a7d01c24f5fdaa07094c3dc6604ab9a > > standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php > 4574c6a4925ae3df9dd1ee7b8786976ae6fc8397 > > standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php > 22deffe1d31a64f95c49d7f017dfeb2994233e71 > > standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote > a595732f04af4304974186178377192227bb80fb > > standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py > 38074ce79b8a06b3795d00431025240778abb569 > > standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py > 38fac465d73c264f85fc512548ebe1919ee35c17 > > standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb > 0192c6da314694c1253b49949bbe749902f49b4b > > standalone-metastore/metastore-common/src/gen/thrift/gen-rb/thrift_hive_metastore.rb > e6a72762bb7b0d36fdf6d20d02cb1da3337a98a0 > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > d226db50a520707abee11fe7b81e2d95c39a6679 > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 54e7eda0da796877f1331de137d534126375c6ba > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > a92f34bb1f149ab063c6f97b80b112f3a9e7f85e > standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift > 85a5c601e03ecd2fb6ac5d30d789193e10bf38c2 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > ba82a9327cf18e8d55ebddcd774786d3d72f753a > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 571c789eddfd2b1a27c65c48bdc6dccfafaaf676 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDirectSqlUtils.java > PRE-CREATION > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 64945060f7152486671c9fe10e2835e67417977c > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionProjectionEvaluator.java > PRE-CREATION > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java > b61ee81533930c889f23d2551041055cbdd1a6b2 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java > 7a0b21b2580d8bb9b256dbc698f125ed15ccdcd3 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > b9a545872f94ffe0a2583c14652e82840d3c6bdd > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MSerDeInfo.java > 68f07e2569b6531cf3e18919209aed1a17e88bf7 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MStorageDescriptor.java > 4c6ce008f89469353bfee3175168a518534a42b1 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java > 10ff9dfbb6d8f61fa75f731f4cd0f006c98e0067 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 0934aeb3a7d5413cacde500a5575e4f676306bd0 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 70a17f51b9b5a9fb0b5640988318fd39a82b895d > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java > ce590d0f5518e4eac570d7ba4885813202dfc0b5 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java > PRE-CREATION > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java > 4937d9d861b13070e7df4f92bf434c40eb1538aa > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestPartitionProjectionEvaluator.java > PRE-CREATION > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java > 30de1c4cfa1cf019186b10583a06da0bf5491634 > > > Diff: https://reviews.apache.org/r/68664/diff/3/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
