----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68917/#review209207 -----------------------------------------------------------
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/conf/JdbcStorageConfigManager.java Line 22 (original), 24 (patched) <https://reviews.apache.org/r/68917/#comment293531> Unused import. jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/GenericJdbcDatabaseAccessor.java Lines 25 (patched) <https://reviews.apache.org/r/68917/#comment293530> Many unused imports. jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/GenericJdbcDatabaseAccessor.java Line 309 (original), 313 (patched) <https://reviews.apache.org/r/68917/#comment293533> In the base code, the key was "hive.sql.dbcp.password" but in the new code it is just "password". Is it a bug in base code? ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java Line 2314 (original), 2304 (patched) <https://reviews.apache.org/r/68917/#comment293534> Incorrect param in comment. ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java Lines 2314 (patched) <https://reviews.apache.org/r/68917/#comment293535> Does it make sense to ignore case when compare here? ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapper.java Lines 29 (patched) <https://reviews.apache.org/r/68917/#comment293536> Unused imports. - Sankar Hariappan On Oct. 3, 2018, 5:59 p.m., Daniel Dai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68917/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2018, 5:59 p.m.) > > > Review request for hive and Sankar Hariappan. > > > Repository: hive-git > > > Description > ------- > > See HIVE-20651 > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties fdd8ecc > jdbc-handler/pom.xml f90892f > > jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/JdbcInputFormat.java > caa823f > > jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/conf/JdbcStorageConfigManager.java > 55fc0ea > > jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/GenericJdbcDatabaseAccessor.java > b2ad9a6 > > jdbc-handler/src/test/java/org/apache/hive/storage/jdbc/TestJdbcInputFormat.java > e904774 > pom.xml 5008923 > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 74fb1ba > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapper.java 99b33a3 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMapRecordHandler.java > 7cd853f > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/MapRecordProcessor.java > ac43917 > ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java a86656c > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 82c3ca9 > ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 250a085 > ql/src/java/org/apache/hadoop/hive/ql/plan/TableDesc.java b73faa5 > ql/src/test/queries/clientpositive/external_jdbc_auth.q PRE-CREATION > ql/src/test/results/clientpositive/llap/external_jdbc_auth.q.out > PRE-CREATION > > > Diff: https://reviews.apache.org/r/68917/diff/1/ > > > Testing > ------- > > > Thanks, > > Daniel Dai > >
