----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68975/#review209735 -----------------------------------------------------------
Thanks Laci! 1 serions question 1 mild one and several annoying nits :) Thanks, Peter ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines 1921 (patched) <https://reviews.apache.org/r/68975/#comment294278> nit: one extra space ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Line 1876 (original) <https://reviews.apache.org/r/68975/#comment294284> This perf logging is removed... Let's think through if we need other places to add some instead considering the new calling structure ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines 2171 (patched) <https://reviews.apache.org/r/68975/#comment294280> What happens when only 1 partiton is already exists from multiple ones? Also, do we need SynchronizedMSC? ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines 2570 (patched) <https://reviews.apache.org/r/68975/#comment294281> Do we need to call this every time in the for loop? I kinda remember that we allow only partitions for a single table only... Or I might be mistaken, but still might be a good idea to not generate this every time... ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines 2687 (patched) <https://reviews.apache.org/r/68975/#comment294283> I am not really a big fun of printing a stacktrace and rethrowing an error, unless I am quite sure that the exception rethrown is not printed later. Otherwise this could be quite confusing. - Peter Vary On okt. 18, 2018, 7:01 de, Laszlo Pinter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68975/ > ----------------------------------------------------------- > > (Updated okt. 18, 2018, 7:01 de) > > > Review request for hive and Peter Vary. > > > Repository: hive-git > > > Description > ------- > > HIVE-20661: Dynamic partitions loading calls add partition for every > partition 1-by-1 > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/metastore/SynchronizedMetaStoreClient.java > 0ab77e84c6222d35bcec9ce95ed02014911ef144 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java > 4de038913a5c9a2c199f71702b8f70ca84d0856b > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > dd23d7db3e70c9540e48c42eb7b9a33ed775cea6 > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > aba63f050b5b98a2aeeb0df6ff2de5e6e06761f2 > > > Diff: https://reviews.apache.org/r/68975/diff/5/ > > > Testing > ------- > > > Thanks, > > Laszlo Pinter > >
