> On Oct. 24, 2018, 8:51 a.m., Antal Sinkovits wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkRecordHandler.java > > Lines 56 (patched) > > <https://reviews.apache.org/r/69107/diff/1/?file=2101701#file2101701line56> > > > > Any reason why we use Timer? > > > > From the timer java docs: > > > > "Java 5.0 introduced the java.util.concurrent package and one of the > > concurrency utilities therein is the ScheduledThreadPoolExecutor which is a > > thread pool for repeatedly executing tasks at a given rate or delay. It is > > effectively a more versatile replacement for the Timer/TimerTask > > combination, as it allows multiple service threads, accepts various time > > units, and doesn't require subclassing TimerTask (just implement Runnable). > > Configuring ScheduledThreadPoolExecutor with one thread makes it equivalent > > to Timer."
I used timer as there was only one thread, bbut I have changed it to ScheduledThreadPoolExecutor, as it looks more extensible - Bharathkrishna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69107/#review209950 ----------------------------------------------------------- On Oct. 24, 2018, 8:55 p.m., Bharathkrishna Guruvayoor Murali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69107/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2018, 8:55 p.m.) > > > Review request for hive, Antal Sinkovits, Sahil Takiar, and Vihang > Karajgaonkar. > > > Repository: hive-git > > > Description > ------- > > Improve record and memory usage logging in SparkRecordHandler > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMapRecordHandler.java > 88dd12c05ade417aca4cdaece4448d31d4e1d65f > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMergeFileRecordHandler.java > 8880bb604e088755dcfb0bcb39689702fab0cb77 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkRecordHandler.java > cb5bd7ada2d5ad4f1f654cf80ddaf4504be5d035 > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkReduceRecordHandler.java > 20e7ea0f4e8d4ff79dddeaab0406fc7350d22bd7 > > > Diff: https://reviews.apache.org/r/69107/diff/2/ > > > Testing > ------- > > > Thanks, > > Bharathkrishna Guruvayoor Murali > >
