> On Oct. 25, 2018, 10:46 p.m., Denys Kuzmenko wrote:
> > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java
> > Lines 1172 (patched)
> > <https://reviews.apache.org/r/69167/diff/1/?file=2102460#file2102460line1172>
> >
> > Could be optimized to:
> >
> > String[] sensitiveData = {"user", "password"};
> > String regex = "([;,\?&]" + String.join("|", sensitiveData) +
> > ")=.*?([;,&\)]+)";
> >
> > String result =
> > Pattern.compile(regex).matcher(connectionURL).replaceAll("$1=***$2");
>
> Denys Kuzmenko wrote:
> or just connectionURL.replaceAll(regex, "$1=***$2");
regex = "([;,?&]" + String.join("|", sensitiveData) + ")=.*?([;,&)]?)";
- Denys
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69167/#review210059
-----------------------------------------------------------
On Oct. 25, 2018, 1:36 p.m., Laszlo Pinter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69167/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2018, 1:36 p.m.)
>
>
> Review request for hive and Peter Vary.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20796: jdbc URL can contain sensitive information that should not be
> logged
>
>
> Diffs
> -----
>
>
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
> 9c158040497cd3d2762620ce35e2b46bb6d5fffe
>
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java
> f3b38665676391fec9b85eb9a405c14632340dc6
>
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java
> f4bdd734dc4e731dda01e6031a4115cde5571baf
>
>
> Diff: https://reviews.apache.org/r/69167/diff/1/
>
>
> Testing
> -------
>
> New unit test created.
>
>
> Thanks,
>
> Laszlo Pinter
>
>
