----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69148/#review210105 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines 5451 (patched) <https://reviews.apache.org/r/69148/#comment294734> nit. Cannot 'create' ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines 5536 (patched) <https://reviews.apache.org/r/69148/#comment294735> nit: Cannot create trigger ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines 5550 (patched) <https://reviews.apache.org/r/69148/#comment294736> nit: trigger similarly for all other exceptions below. To say what specific resource is being created/modified/dropped ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java Lines 434 (patched) <https://reviews.apache.org/r/69148/#comment294737> unused :) ql/src/test/results/clientpositive/llap/resourceplan.q.out Line 3918 (original), 3970 (patched) <https://reviews.apache.org/r/69148/#comment294738> hmm.. expected? ql/src/test/results/clientpositive/llap/resourceplan.q.out Line 4051 (original), 4101 (patched) <https://reviews.apache.org/r/69148/#comment294739> Similarly are these support to show up in clientpositive tests? ql/src/test/results/clientpositive/llap/resourceplan.q.out Line 4713 (original), 4763 (patched) <https://reviews.apache.org/r/69148/#comment294740> can you add a non-default ns test as well? - Prasanth_J On Oct. 25, 2018, 9:43 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69148/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2018, 9:43 p.m.) > > > Review request for hive, Jason Dere and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > e226a1f82d44550f389308f91d578e7aa4ea170a > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java > c3e1e8e88c69d7713e16c7061ce8cf73a0d5e833 > metastore/scripts/upgrade/hive/hive-schema-4.0.0.hive.sql > a69046f961cdf0fff7989492c489bb62f2a66d72 > metastore/scripts/upgrade/hive/upgrade-3.1.0-to-4.0.0.hive.sql > 4c770206fe3dcceb8570be1c1ef078b376f5cafd > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java > 807f159daa98d40e667914adc6c53fb8ecabf998 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java > 4de038913a5c9a2c199f71702b8f70ca84d0856b > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java > e57db935d9420508ed6091e12ca6b6cd3382db5d > ql/src/test/queries/clientpositive/resourceplan.q > fae9701ebaeaa521904a383f5fb741c13be08d8e > ql/src/test/results/clientpositive/llap/resourceplan.q.out > c11daf728cdd5bd6fe36618aff113b3d60579129 > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > aba63f050b5b98a2aeeb0df6ff2de5e6e06761f2 > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > d1c0c4d1f60016f28cea69348b1b30ecb61bf083 > standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift > 4b7b61520a2d55635f474317053a17410f3a4bb7 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 8cd46e3f44e7c4e47fbf7f2ce2b6350a5814106f > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 9c158040497cd3d2762620ce35e2b46bb6d5fffe > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java > c3914b668fac18ead6196a4fc449e909f5af01b1 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > 47ac68c667bea8f09f5301a6364c854bc18b3c0d > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java > ac51f2d77145b37da468ce8df2ac5c42f4d6c538 > standalone-metastore/metastore-server/src/main/resources/package.jdo > fef6a42038bb2aa0cba6dfda8d710fd37cb720e7 > > standalone-metastore/metastore-server/src/main/sql/derby/hive-schema-4.0.0.derby.sql > c889bbdf96b887b29be858e41ee854f0731cd5cd > > standalone-metastore/metastore-server/src/main/sql/derby/upgrade-3.2.0-to-4.0.0.derby.sql > aca5227a5bb6192da6c5f070c04d2941d636bad2 > > standalone-metastore/metastore-server/src/main/sql/mssql/hive-schema-4.0.0.mssql.sql > 91ba134325094e413887a89e1d605efa99218288 > > standalone-metastore/metastore-server/src/main/sql/mssql/upgrade-3.2.0-to-4.0.0.mssql.sql > f0d861b3a9bc982c1e24fa49415dcfc6c105cd68 > > standalone-metastore/metastore-server/src/main/sql/mysql/hive-schema-4.0.0.mysql.sql > 3af2ebb253f82bb85976d229d4ac2225deffdbde > > standalone-metastore/metastore-server/src/main/sql/mysql/upgrade-3.2.0-to-4.0.0.mysql.sql > ee0f691b524a6e822ac14e09d24d3a49ae8565b1 > > standalone-metastore/metastore-server/src/main/sql/oracle/hive-schema-4.0.0.oracle.sql > 33aa08015a9e17585c42d64d44b364be96e69eaf > > standalone-metastore/metastore-server/src/main/sql/oracle/upgrade-3.2.0-to-4.0.0.oracle.sql > bbb4a39ec4f6f616c9a1a9042a35cafd45cf9796 > > standalone-metastore/metastore-server/src/main/sql/postgres/hive-schema-4.0.0.postgres.sql > ea088d77fdaec85834b8fd3f01eacdfac58dd245 > > standalone-metastore/metastore-server/src/main/sql/postgres/upgrade-3.2.0-to-4.0.0.postgres.sql > 2a2d70ae802eb6f5b9ab7f4f9519a0af30d2c5b4 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 966979891b71f1cbfe50f56c40c35af8b304c47f > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 593d562c3498660861201f58d83c27d59d184046 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java > 4293579ad8b55d59f2230040f23e9a693d838ca7 > > > Diff: https://reviews.apache.org/r/69148/diff/2/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
