-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69262/#review210357
-----------------------------------------------------------




llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java
Lines 191 (patched)
<https://reviews.apache.org/r/69262/#comment295021>

    the credentials field is optional in pb but this is using it without a check



llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java
Lines 318 (patched)
<https://reviews.apache.org/r/69262/#comment295020>

    why would it be null


- Sergey Shelukhin


On Nov. 6, 2018, 10:26 p.m., Jaume Marhuenda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69262/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2018, 10:26 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Expose ShuffleHandler.registerDag in the llap daemon API
> 
> 
> Diffs
> -----
> 
>   
> llap-client/src/java/org/apache/hadoop/hive/llap/tez/LlapProtocolClientProxy.java
>  211696a0b5 
>   
> llap-common/src/gen/protobuf/gen-java/org/apache/hadoop/hive/llap/daemon/rpc/LlapDaemonProtocolProtos.java
>  8fecc1e920 
>   
> llap-common/src/java/org/apache/hadoop/hive/llap/impl/LlapProtocolClientImpl.java
>  bdffbbfc22 
>   llap-common/src/protobuf/LlapDaemonProtocol.proto d70dd41a83 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/ContainerRunner.java 
> 035960e347 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/LlapDaemonUtils.java 
> PRE-CREATION 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java
>  ef5922ef41 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 
> 52990c5f05 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapProtocolServerImpl.java
>  d856b2580a 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java
>  ab84dcc5b3 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/shufflehandler/ShuffleHandler.java
>  18a37a2adc 
>   
> llap-server/src/test/org/apache/hadoop/hive/llap/daemon/LlapDaemonTestUtils.java
>  PRE-CREATION 
>   
> llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestContainerRunnerImpl.java
>  PRE-CREATION 
>   
> llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/comparator/TestFirstInFirstOutComparator.java
>  d3aa53942b 
>   
> llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java
>  5d4ce223d9 
>   
> llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
>  7e8299d156 
>   llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTezUtils.java 
> e4af660fff 
> 
> 
> Diff: https://reviews.apache.org/r/69262/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaume Marhuenda
> 
>

Reply via email to