> On 2011-12-19 22:45:48, Carl Steinbach wrote: > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java, > > line 279 > > <https://reviews.apache.org/r/2975/diff/3/?file=65044#file65044line279> > > > > > you dont want existing application to break when server is upgraded > > and is running with setugi on > > > > Right, but this is the client-side, which is a little different. If the > > client requests set_ugi and doesn't get it I think it may be better to > > throw an exception. Right now it doesn't seem like the client has any way > > of knowing whether or not their set_ugi request has been honored.
> Right, but this is the client-side, which is a little different. If the > client requests set_ugi and doesn't get it I think it may be better to throw > an exception. Since this is a current behavior, I am inclined to keep it that way. If we throw an exception, this will be change of behavior and will surprise those apps. > Right now it doesn't seem like the client has any way of knowing whether or > not their set_ugi request has been honored. Client catches TException and logs it, so client can know about it, if it wants to. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2975/#review3987 ----------------------------------------------------------- On 2011-12-17 02:42:36, Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2975/ > ----------------------------------------------------------- > > (Updated 2011-12-17 02:42:36) > > > Review request for hive. > > > Summary > ------- > > Pass user identity in metastore connection in unsecure mode > > > This addresses bug HIVE-2616. > https://issues.apache.org/jira/browse/HIVE-2616 > > > Diffs > ----- > > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1215380 > trunk/conf/hive-default.xml.template 1215380 > trunk/metastore/if/hive_metastore.thrift 1215380 > trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1215380 > trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1215380 > > trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp > 1215380 > > trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java > 1215380 > > trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php > 1215380 > > trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote > 1215380 > trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py > 1215380 > trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1215380 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 1215380 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 1215380 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/TUGIBasedProcessor.java > PRE-CREATION > trunk/shims/ivy.xml 1215380 > trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java > 1215380 > trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java > 1215380 > > trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java > 1215380 > > trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/client/TUGIAssumingTransport.java > PRE-CREATION > trunk/shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java > 1215380 > > trunk/shims/src/common/java/org/apache/hadoop/hive/thrift/TFilterTransport.java > PRE-CREATION > > trunk/shims/src/common/java/org/apache/hadoop/hive/thrift/TUGIContainingTransport.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/2975/diff > > > Testing > ------- > > All the tests in metastore dir passes. Manually tested that file on hdfs is > owned by user running the client and not by user running metastore server. > > > Thanks, > > Ashutosh > >
