BELUGA BEHR created HIVE-21073:
----------------------------------

             Summary: Remove Extra String Object
                 Key: HIVE-21073
                 URL: https://issues.apache.org/jira/browse/HIVE-21073
             Project: Hive
          Issue Type: Improvement
    Affects Versions: 3.1.1, 4.0.0
            Reporter: BELUGA BEHR


{code}
  public static String generatePath(Path baseURI, String filename) {
    String path = new String(baseURI + Path.SEPARATOR + filename);
    return path;
  }

  public static String generateFileName(Byte tag, String bigBucketFileName) {
    String fileName = new String("MapJoin-" + tag + "-" + bigBucketFileName + 
suffix);
    return fileName;
  }
{code}

It's a bit odd to be performing string concatenation and then wrapping the 
results in a new string.  This is creating superfluous String objects. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to