----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69672/#review211698 -----------------------------------------------------------
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PersistenceManagerProvider.java Line 228 (original), 227 (patched) <https://reviews.apache.org/r/69672/#comment297206> I cleaned up this code a little bit. The code in master had this logic where it checked if there are custom properties (through the function hasProviderSpecificConfigurations) which started with "hikaricp", "bonecp" etc. These custom properties should not matter becuase based on "datanuclues.connectionPoolType" property, we just create the appropriate pooling data source and pass in all the properties. New logic is that it looks at the connectionPoolingType property, checks if there is a DataSourceProvider avaialble for the set property and creates one. If not, we fallback to the default JDOHelper.getPersistenceManagerFactory logic. Please correct me if I am wrong in my understanding here. - Karthik Manamcheri On Jan. 5, 2019, 12:35 a.m., Karthik Manamcheri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69672/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2019, 12:35 a.m.) > > > Review request for hive, Adam Holley, Morio Ramdenbourg, Naveen Gangam, and > Vihang Karajgaonkar. > > > Repository: hive-git > > > Description > ------- > > HIVE-21045: Add total API timing stats and connection pool stats to metrics > > > Diffs > ----- > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PersistenceManagerProvider.java > dfd7abff85 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/BoneCPDataSourceProvider.java > 7e33c519a8 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/DataSourceProvider.java > 6dc63fb3bc > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/DataSourceProviderFactory.java > 5a92e104be > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/DbCPDataSourceProvider.java > 7fe487b184 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java > 8f6ae57e36 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metrics/MetricsConstants.java > 3b188f83af > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metrics/PerfLogger.java > a2def26fc5 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 2a6290315a > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/datasource/TestDataSourceProviderFactory.java > 6ae7f50471 > > > Diff: https://reviews.apache.org/r/69672/diff/1/ > > > Testing > ------- > > Manual testing to verify that the new metrics show up for hikaricp, bonecp, > and also the total stats. Here are samples of > 1. [HikariCP json metrics > sample](https://gist.github.com/kmanamcheri/48ff2a680e85c7e925a6f95a9384dcef) > 2. [BoneCP json metrics > sample](https://gist.github.com/kmanamcheri/b005f68263a1a1be06b25156a159d975) > > In both the reports note that there are pool gauges (for tracking the > connection pool info) and also a timer for total api calls. > > > Thanks, > > Karthik Manamcheri > >
