GitHub user xiasiyu opened a pull request:

    https://github.com/apache/hive/pull/512

    fix null string check for C++ using thrift api

    thrift generate C++ files, using (std::string& principalName) as 
list_privileges parameters. When it only checks null in java code, null string 
can not be passed by C++ api only if generated source code is modified.
    api in generated ThriftHiveMetastore.h is:
    void list_privileges(std::vector & _return, const std::string& 
principal_name, const PrincipalType::type principal_type, const HiveObjectRef& 
hiveObject);

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xiasiyu/hive patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/hive/pull/512.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #512
    
----
commit 54fa2bf3dae195027b61eb78f7cb499bcd19f0ad
Author: Summer Xia <xiasiyu@...>
Date:   2019-01-10T03:57:51Z

    fix null string check for C++ using thrift api
    
    thrift generate C++ files, using (std::string& principalName) as 
list_privileges parameters. When it only checks null in java code, null string 
can not be passed by C++ api only if generated source code is modified.
    api in generated ThriftHiveMetastore.h is:
    void list_privileges(std::vector & _return, const std::string& 
principal_name, const PrincipalType::type principal_type, const HiveObjectRef& 
hiveObject);

----


---

Reply via email to