-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69704/
-----------------------------------------------------------

(Updated Jan. 28, 2019, 10:32 p.m.)


Review request for hive.


Repository: hive-git


Description
-------

Make sure transaction get cleaned if they are aborted before addPartitions is 
called


Diffs (updated)
-----

  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java
 dc7b2877bf 
  ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 5dbf634825 
  ql/src/java/org/apache/hadoop/hive/ql/io/HdfsUtils.java 3482cfce36 
  ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java 06b0209aa0 
  
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CleanerExecutorService.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java a0df82cb20 
  
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/NonReentrantReadWriteLock.java
 PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java 
5e085f84af 
  
ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestCleanerExecutorService.java
 PRE-CREATION 
  shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java 
b6f70ebe63 
  shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java 
c569b242ae 
  
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/CompactionType.java
 7450b27cf3 
  
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php
 13e287e352 
  
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py
 8f149d1d6e 
  
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb
 9e5f0860f2 
  
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
 be1f8c7849 
  standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift 
9576f8775a 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionInfo.java
 ea70503988 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java
 8253ccb9c9 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
 91a9ab4053 
  
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java
 898a94dcd6 


Diff: https://reviews.apache.org/r/69704/diff/4/

Changes: https://reviews.apache.org/r/69704/diff/3-4/


Testing
-------

Planning to manually test it using the hive-spark connector, which is where 
this bug was discovered.


Thanks,

Jaume Marhuenda

Reply via email to