cricket007 commented on a change in pull request #526: HIVE-21218: KafkaSerDe
doesn't support topics created via Confluent
URL: https://github.com/apache/hive/pull/526#discussion_r254991986
##########
File path: kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaSerDe.java
##########
@@ -369,6 +379,20 @@ private SubStructObjectInspector(StructObjectInspector
baseOI, int toIndex) {
}
}
+ static class ConfluentAvroBytesConverter extends AvroBytesConverter {
+ ConfluentAvroBytesConverter(Schema schema) {
+ super(schema);
+ }
+
+ @Override
+ Decoder getDecoder(byte[] value) {
+ /**
+ * Confluent 4 magic bytes that represents Schema ID as Integer. These
bits are added before value bytes.
+ */
+ return DecoderFactory.get().binaryDecoder(value, 5, value.length - 5,
null);
Review comment:
> About the compatibility, there are several compatibility modes in schema
registry. It can be set for each topic and you can set BACKWARD compat
Right, but Hive will likely only work properly if the config really is set
to backwards, or at the least, the schema provided can read all the data for
the offsets that are scanned .
> with literally different schemas
Maybe if more schema data was exposed, this would be easier to handle? For
example, the Avro namespace + top-level record name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
