kgyrtkirk commented on a change in pull request #543: HIVE-21292: Break up
DDLTask 1 - extract Database related operations
URL: https://github.com/apache/hive/pull/543#discussion_r259298189
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
##########
@@ -2571,11 +2567,10 @@ private void analyzeDescDatabase(ASTNode ast) throws
SemanticException {
throw new SemanticException("Unexpected Tokens at DESCRIBE DATABASE");
}
- DescDatabaseDesc descDbDesc = new DescDatabaseDesc(ctx.getResFile(),
- dbName, isExtended);
+ DescDatabaseDesc descDbDesc = new DescDatabaseDesc(ctx.getResFile(),
dbName, isExtended);
inputs.add(new ReadEntity(getDatabase(dbName)));
- rootTasks.add(TaskFactory.get(new DDLWork(getInputs(), getOutputs(),
descDbDesc)));
- setFetchTask(createFetchTask(descDbDesc.getSchema()));
+ rootTasks.add(TaskFactory.get(new DDLWork2(getInputs(), getOutputs(),
descDbDesc)));
+ setFetchTask(createFetchTask(DESC_DATABASE_SCHEMA));
Review comment:
I think the `schema` should works similarily to earlier; how about asking
the DDLWork for the schema? it could look up based on the desc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
