sankarh commented on a change in pull request #541: HIVE-21197 : Hive Replication can add duplicate data during migration to a target with hive.strict.managed.tables enabled URL: https://github.com/apache/hive/pull/541#discussion_r259736959
########## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java ########## @@ -1164,6 +1168,9 @@ private static void createReplImportTasks( if (x.getEventType() == DumpType.EVENT_CREATE_TABLE) { dropTblTask = dropTableTask(table, x, replicationSpec); table = null; + } else if (!firstIncPending) { + // For table level replication, get the flag from table parameter. Check HIVE-21197 for more detail. + firstIncPending = ReplUtils.isFirstIncPending(table.getParameters()); Review comment: For insert or alter events where previous event is create table, then referring to firstincpending flag could be wrong for table level replication. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services