kgyrtkirk commented on a change in pull request #544: HIVE-16924 Support
distinct in presence of Group By
URL: https://github.com/apache/hive/pull/544#discussion_r260653418
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
##########
@@ -4195,21 +4195,18 @@ public static long unsetBit(long bitmap, int bitIdx) {
* DISTINCT, if present, will be handled when generating the SELECT.
*/
List<ASTNode> getGroupByForClause(QBParseInfo parseInfo, String dest) throws
SemanticException {
- // When *not* invoked by CalcitePlanner, return the DISTINCT as a GBY
- // CBO will handle the DISTINCT in
CalcitePlannerAction.genSelectLogicalPlan
ASTNode selectExpr = parseInfo.getSelForClause(dest);
Collection<ASTNode> aggregateFunction =
parseInfo.getDestToAggregationExprs().get(dest).values();
- if (isSelectDistinct(selectExpr) && !isGroupBy(selectExpr) &&
!isAggregateInSelect(selectExpr, aggregateFunction)) {
+ if (isSelectDistinct(selectExpr) && !hasGroupBySibling(selectExpr) &&
+ !isAggregateInSelect(selectExpr, aggregateFunction)) {
List<ASTNode> result = new ArrayList<ASTNode>(selectExpr == null ? 0 :
selectExpr.getChildCount());
Review comment:
remove this `== null` check ; it's not needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
