maheshk114 commented on a change in pull request #559: HIVE-21403: Incorrect 
error code returned when retry bootstrap with different dump.
URL: https://github.com/apache/hive/pull/559#discussion_r263339205
 
 

 ##########
 File path: 
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosExternalTables.java
 ##########
 @@ -548,6 +549,37 @@ public void 
bootstrapExternalTablesDuringIncrementalPhase() throws Throwable {
     );
   }
 
+  @Test
+  public void 
retryIncBootstrapExternalTablesFromDifferentDumpWithoutCleanTablesConfig() 
throws Throwable {
+    List<String> dumpWithClause = Collections.singletonList(
+            "'" + HiveConf.ConfVars.REPL_INCLUDE_EXTERNAL_TABLES.varname + 
"'='false'"
+    );
+    List<String> loadWithClause = externalTableBasePathWithClause();
+
+    WarehouseInstance.Tuple tupleBootstrapWithoutExternal = primary
+            .run("use " + primaryDbName)
+            .run("create external table t1 (id int)")
+            .run("insert into table t1 values (1)")
+            .run("create table t2 as select * from t1")
+            .dump(primaryDbName, null, dumpWithClause);
+
+    replica.load(replicatedDbName, tupleBootstrapWithoutExternal.dumpLocation, 
loadWithClause);
 
 Review comment:
   if dump is with out external then for load no need of external

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to