animenon commented on a change in pull request #388: HIVE-20057: Fix Hive table
conversion DESCRIBE table bug
URL: https://github.com/apache/hive/pull/388#discussion_r264023163
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -1802,12 +1802,12 @@ private MTable convertToMTable(Table tbl) throws
InvalidObjectException,
// accordingly
String tableType = tbl.getTableType();
boolean isExternal =
Boolean.parseBoolean(tbl.getParameters().get("EXTERNAL"));
- if (TableType.MANAGED_TABLE.toString().equals(tableType)) {
+ if (TableType.MANAGED_TABLE.toString().equalsIgnoreCase(tableType)) {
Review comment:
Yes the `Boolean.parseBoolean` would ignore case and give correct
`isExternal` value, but the thing is you wouldn't reach there..
`TableType.EXTERNAL_TABLE equals tableType` is checked before `if
(!isExternal)` that would fail.
[ref](https://github.com/apache/hive/blob/e4d60e29910ec709d432fd85819cb6b6d097d689/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L1811)
Like you pointed out rightly, `isExternal` ignores case but the flow
wouldn't goto that condition because the condition before that fails.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
