----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70256/ -----------------------------------------------------------
Review request for hive, Adam Holley, Karthik Manamcheri, Karen Coppage, and Vihang Karajgaonkar. Repository: hive-git Description ------- This test was not correctly counting the number of objects in the PersistenceManager cache before and after HiveMetaStoreClient.close(). The getJDOPersistenceManagerCacheSize() internal helper method did not use the updated fields present in the metastore classes, and was consistently returning -1. Additionally, there was a chance to cause flakiness since the object count before and after close() could differ depending on lingering objects from previous tests or setup. Modified the helper method to use the new fields, and fixed the flakiness on this test. Diffs ----- standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 77e0c98265e7b561f2eb39536e3251dd92e9cab0 Diff: https://reviews.apache.org/r/70256/diff/1/ Testing ------- Unit tests run Thanks, Morio Ramdenbourg
