-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70372/
-----------------------------------------------------------
(Updated April 5, 2019, 11:05 p.m.)
Review request for hive, Ashutosh Chauhan and Jason Dere.
Changes
-------
The timestamp change to ConvertAstToSearchArg is incorrect. Orc does not handle
TIMESTAMP and TIMESTAMPLOCALTZ types correctly. ORC-189 is required. The
timestamps in syslog all assume UTC (TIMESTAMP type), but expression filters in
syslog_parser_file_pruning.q gets converted to local TZ (TIMESTAMPLOCALTZ)
giving incorrect results. Also there is no way to force using UTC for the qfile
tests. If we pass "-Duser.timezone=UTC" while running qfile it gives correct
results but then precommit servers cannot run qfile test with
"-Duser.timezone=UTC" option. We probably need a separate CliDriver for qfile
tests that runs tests in UTC but that is out of scope for this ticket. I will
disable syslog_parser_file_pruning.q for now as enabling it will give incorrect
results depending on which TZ ptest server runs. Also reverted changes to
ConvertAstToSearchArg.java file as ORC-189 will take care it.
Bugs: HIVE-21427
https://issues.apache.org/jira/browse/HIVE-21427
Repository: hive-git
Description
-------
HIVE-21427: Syslog storage handler
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java aa27a01174
data/files/syslog-hs2-2.log PRE-CREATION
data/files/syslog-hs2-exception.log PRE-CREATION
data/files/syslog-hs2.log PRE-CREATION
itests/src/test/resources/testconfiguration.properties 96dfbc4b56
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java
6f04602acb
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java
9ef7af4eb0
ql/src/java/org/apache/hadoop/hive/ql/log/syslog/SyslogInputFormat.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/log/syslog/SyslogParser.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/log/syslog/SyslogSerDe.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/log/syslog/SyslogStorageHandler.java
PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/log/TestSyslogInputFormat.java
PRE-CREATION
ql/src/test/queries/clientpositive/syslog_parser.q PRE-CREATION
ql/src/test/queries/clientpositive/syslog_parser_exception.q PRE-CREATION
ql/src/test/queries/clientpositive/syslog_parser_file_pruning.q PRE-CREATION
ql/src/test/results/clientpositive/llap/syslog_parser.q.out PRE-CREATION
ql/src/test/results/clientpositive/llap/syslog_parser_exception.q.out
PRE-CREATION
ql/src/test/results/clientpositive/llap/syslog_parser_file_pruning.q.out
PRE-CREATION
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/schematool/MetastoreSchemaTool.java
eafe0c6d46
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/schematool/SchemaToolCommandLine.java
6282078411
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/schematool/SchemaToolTaskCreateLogsTable.java
PRE-CREATION
Diff: https://reviews.apache.org/r/70372/diff/5/
Changes: https://reviews.apache.org/r/70372/diff/4-5/
Testing
-------
Thanks,
Prasanth_J
