-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70873/
-----------------------------------------------------------
Review request for hive and Zoltan Haindrich.
Bugs: HIVE-21881
https://issues.apache.org/jira/browse/HIVE-21881
Repository: hive-git
Description
-------
DDLTask is a huge class, more than 5000 lines long. The related DDLWork is also
a huge class, which has a field for each DDL operation it supports. The goal is
to refactor these in order to have everything cut into more handleable classes
under the package org.apache.hadoop.hive.ql.exec.ddl:
have a separate class for each operation
have a package for each operation group (database ddl, table ddl, etc), so the
amount of classes under a package is more manageable
make all the requests (DDLDesc subclasses) immutable
DDLTask should be agnostic to the actual operations
right now let's ignore the issue of having some operations handled by DDLTask
which are not actual DDL operations (lock, unlock, desc...)
In the interim time when there are two DDLTask and DDLWork classes in the code
base the new ones in the new package are called DDLTask2 and DDLWork2 thus
avoiding the usage of fully qualified class names where both the old and the
new classes are in use.
Step #11: extract the operations that left from the old DDLTask, and move them
under the new packages.
Diffs
-----
hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzerBase.java
e84dfdc931
ql/src/java/org/apache/hadoop/hive/ql/ddl/misc/CacheMetadataDesc.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/misc/CacheMetadataOperation.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/misc/InsertCommitHookOperation.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/misc/MsckDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/misc/MsckOperation.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/misc/ReplRemoveFirstIncLoadPendFlagOperation.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/misc/ShowConfOperation.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/misc/package-info.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/CreateViewDesc.java 595da9c5ea
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 89dca2e7bd
ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 04d12075a5
ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java 6ac695d502
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/incremental/IncrementalLoadTasksBuilder.java
f6975d3362
ql/src/java/org/apache/hadoop/hive/ql/optimizer/QueryPlanPostProcessor.java
3f5b0e3e36
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
f13593e36c
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1a2a1e8f47
ql/src/java/org/apache/hadoop/hive/ql/plan/CacheMetadataDesc.java e061adb757
ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 639aaba9e8
ql/src/java/org/apache/hadoop/hive/ql/plan/InsertCommitHookDesc.java
8136506381
ql/src/java/org/apache/hadoop/hive/ql/plan/MsckDesc.java 5d2307c168
ql/src/java/org/apache/hadoop/hive/ql/plan/ReplRemoveFirstIncLoadPendFlagDesc.java
afa0a09af2
ql/src/java/org/apache/hadoop/hive/ql/plan/ShowConfDesc.java 9efecb1845
ql/src/test/org/apache/hadoop/hive/ql/plan/TestConditionalResolverCommonJoin.java
6ee74ca257
ql/src/test/queries/clientpositive/msck_repair_drop.q 407249e55a
ql/src/test/queries/clientpositive/show_conf.q 064358d49d
ql/src/test/queries/clientpositive/stats_filemetadata.q 5ddbaac626
ql/src/test/results/clientnegative/msck_repair_1.q.out 174419fe44
ql/src/test/results/clientnegative/msck_repair_2.q.out 174419fe44
ql/src/test/results/clientnegative/msck_repair_3.q.out 174419fe44
ql/src/test/results/clientnegative/msck_repair_4.q.out bb9cf47b08
ql/src/test/results/clientnegative/table_nonprintable_negative.q.out
3891747c8d
ql/src/test/results/clientpositive/druid/druidmini_dynamic_partition.q.out
1401dbc375
ql/src/test/results/clientpositive/druid/druidmini_mv.q.out 08a83da67a
ql/src/test/results/clientpositive/msck_repair_drop.q.out 27b718c670
ql/src/test/results/clientpositive/show_conf.q.out 7e65dfd31e
Diff: https://reviews.apache.org/r/70873/diff/1/
Testing
-------
All the unit tests are still running + added some new init tests.
Thanks,
Miklos Gergely
