----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70867/#review215963 -----------------------------------------------------------
Ship it! Thanks for the patch. I have two minor hints, otherwise the change looks good to me. Just please consider them before the new batch of partitioned temp table changes. - Marta Kuczora On June 17, 2019, 3:36 p.m., Laszlo Pinter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70867/ > ----------------------------------------------------------- > > (Updated June 17, 2019, 3:36 p.m.) > > > Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita. > > > Repository: hive-git > > > Description > ------- > > HIVE-21814: Implement list partitions related methods on temporary tables > > This change is the next step to support partitions on temporary tables. > HIVE-18739 and HIVE-20661 added partial support for partition columns on > temporary tables, but it was not complete and it was available only for > internal usage. This change addresses the missing functionality related to > listing partitions from temporary tables, although is still remains unexposed > until all the partition related functionalities (get, list, add, alter etc.) > are implemented. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > b71ef5a725d610cda402717f501f6c6a0f653216 > > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientListPartitionsTempTable.java > PRE-CREATION > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/ConditionalIgnoreOnSessionHiveMetastoreClient.java > 99039b08d014cddc9de12e70801267eba7331266 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java > 34ceb34de646cc2e501564e9b3a0cb8cc8a034e1 > > > Diff: https://reviews.apache.org/r/70867/diff/1/ > > > Testing > ------- > > Unit testing is done via > TestSessionHiveMetastoreClientListPartitionsTempTable. > > > Thanks, > > Laszlo Pinter > >
