----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70934/#review216150 -----------------------------------------------------------
Ship it! Thanks a lot for the patch. It looks good to me. - Marta Kuczora On June 25, 2019, 12:47 p.m., Laszlo Pinter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70934/ > ----------------------------------------------------------- > > (Updated June 25, 2019, 12:47 p.m.) > > > Review request for hive, Eugene Koifman, Marta Kuczora, Peter Vary, and Adam > Szita. > > > Repository: hive-git > > > Description > ------- > > HIVE-18735: Create table like loses transactional attribute. > > > Diffs > ----- > > hbase-handler/src/test/results/positive/hbase_queries.q.out > 0c21d6d74882788d5748639ea2675579893791af > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > d395db1b59d021789b1bb47c7f09ff337cba2dd0 > ql/src/test/results/clientpositive/alter_rename_table.q.out > dd656954a1877f7f808de81f6952d7cf8ebfda2f > ql/src/test/results/clientpositive/alter_table_stats_status.q.out > efa2834e0d6dbd77181473c214b77d09fcc1fe69 > ql/src/test/results/clientpositive/autoColumnStats_1.q.out > 1f594ddb6816805d22a1152c261dda75490cd5d0 > ql/src/test/results/clientpositive/autoColumnStats_2.q.out > 121a10384bca03942c297dd0488aceaf0d3bed68 > ql/src/test/results/clientpositive/autoColumnStats_3.q.out > 777d165dc26fb11a6fd863fe1f375c6ae3d55b2a > ql/src/test/results/clientpositive/autoColumnStats_8.q.out > 0e1868bd52d717a6103f1456a1d4e525e85d8622 > ql/src/test/results/clientpositive/create_alter_list_bucketing_table1.q.out > 593ae8389971449ad0f8704d911f6f22227c6bcc > ql/src/test/results/clientpositive/create_like.q.out > f4a5ed55a568b0160a6c87cb2fe8c7cd9b20c7c8 > ql/src/test/results/clientpositive/create_like2.q.out > 7152f52fcf82d5052a67be6e27bda532f2b521bd > ql/src/test/results/clientpositive/create_like_tbl_props.q.out > 4d11fc3c9e39c18dd18fdb585ad1831a0a068768 > ql/src/test/results/clientpositive/create_table_like_stats.q.out > 4aa1b4f167a99ffc97d97bb62e0f5313fd83314e > ql/src/test/results/clientpositive/describe_table.q.out > 8c7a16c4b65d3f3951e6c230c42325056a7eab0b > ql/src/test/results/clientpositive/erasurecoding/erasure_simple.q.out > 3ceb3d03c2614f3256a822c9f105ed6e9f2bada8 > ql/src/test/results/clientpositive/explain_ddl.q.out > c53ffae8003bdcc320d4910f021c821c0777bdeb > ql/src/test/results/clientpositive/llap/autoColumnStats_1.q.out > 7272a9c925a4115ee3f1d3a4e6576057d75ac994 > ql/src/test/results/clientpositive/llap/autoColumnStats_2.q.out > 1a4b164b0925860543dd74215e0820fe84c5f3f1 > > ql/src/test/results/clientpositive/llap/insert_values_orig_table_use_metadata.q.out > 6c892cc5b87960b086d90c43516526056bdf221f > ql/src/test/results/clientpositive/llap/stats_noscan_1.q.out > af55d23484ddb74a2c5b7f06c4e91a6063ae11dc > ql/src/test/results/clientpositive/llap/whroot_external1.q.out > cac158c92669f1ad532ada3d6620adebeb909eae > ql/src/test/results/clientpositive/load_dyn_part8.q.out > 7b1b5c1f862a581af3b2c4cabe21b6d186601652 > ql/src/test/results/clientpositive/merge3.q.out > 4e670558808894b0dd5f7b8815987e03de1dc6d3 > ql/src/test/results/clientpositive/mm_default.q.out > 70519b7da8346ddc2de74e46010183d2c9ab11ee > ql/src/test/results/clientpositive/partition_discovery.q.out > cddb6e56ba8db9162c491125e3efd3acd2ed29b2 > ql/src/test/results/clientpositive/spark/load_dyn_part8.q.out > aebf4382cd78b02d9b7bab7285254431f04e29c0 > ql/src/test/results/clientpositive/spark/stats12.q.out > 9db43ef112d0898c08429c839e196b3e48067383 > ql/src/test/results/clientpositive/spark/stats13.q.out > 4922d717a0074146d6da91aae859f09aa5a2b623 > ql/src/test/results/clientpositive/spark/stats14.q.out > eb8a995e298d77098c5d7a01086943dc08307c19 > ql/src/test/results/clientpositive/spark/stats15.q.out > 3874e6de249428404946f461eec3575d6dcb50a5 > ql/src/test/results/clientpositive/spark/stats2.q.out > 30339caeb2cff5cc96101d8cbf5f3ed8b5b01667 > ql/src/test/results/clientpositive/spark/stats6.q.out > 77be16cb13558e6b2af2e772ff0505ea4dba8125 > ql/src/test/results/clientpositive/spark/stats7.q.out > fe942ad94b35288b0cc74d1434429378835ce9c2 > ql/src/test/results/clientpositive/spark/stats8.q.out > edfbd57f72b55d040233328330562703286627d3 > ql/src/test/results/clientpositive/spark/stats9.q.out > ed226b68d21733c7d371472d99f714b759e380e2 > ql/src/test/results/clientpositive/spark/stats_noscan_1.q.out > 32001f6a6812ea7768933a0b479d2107265ef799 > ql/src/test/results/clientpositive/stats12.q.out > 50cdace04384f9408298de50a426a22149605563 > ql/src/test/results/clientpositive/stats13.q.out > c6364ebf1d8cabe4818c9788d2819e8a4d7a0726 > ql/src/test/results/clientpositive/stats14.q.out > faebe8afd83a271a31bb88a51f0b8b6072f69209 > ql/src/test/results/clientpositive/stats15.q.out > 2bfc6751e9b3300445acda1a967d4d9d39c856ee > ql/src/test/results/clientpositive/stats2.q.out > e1bd37f393310385ed8dbcef88c6fa8bbc93d16c > ql/src/test/results/clientpositive/stats4.q.out > c61fb6f2fcc848d8cd4c16836ad7b1933b3346f8 > ql/src/test/results/clientpositive/stats6.q.out > 77be16cb13558e6b2af2e772ff0505ea4dba8125 > ql/src/test/results/clientpositive/stats7.q.out > bdf6f8602ccfeed6adffdd1f48b8c55cca52c0e3 > ql/src/test/results/clientpositive/stats8.q.out > 43e94c723d972dac7a436088e47966265f3015de > ql/src/test/results/clientpositive/stats9.q.out > 979a934b86c7b4668c4ff2cc5fcdc9c937a09faa > ql/src/test/results/clientpositive/stats_noscan_1.q.out > 32001f6a6812ea7768933a0b479d2107265ef799 > ql/src/test/results/clientpositive/tez/explainanalyze_5.q.out > 68e8e5a24a66be82fd1cb856b586ab296b665e1b > > > Diff: https://reviews.apache.org/r/70934/diff/2/ > > > Testing > ------- > > > Thanks, > > Laszlo Pinter > >
