-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71571/
-----------------------------------------------------------

(Updated Oct. 2, 2019, 7:41 a.m.)


Review request for hive, Jesús Camacho Rodríguez, Zoltan Haindrich, and Vineet 
Garg.


Bugs: HIVE-22240
    https://issues.apache.org/jira/browse/HIVE-22240


Repository: hive-git


Description
-------

Function percentile_cont fails when array parameter passed
==========================================================
The method `GenericUDAFPercentileCont.iterate` expect a `HiveDecimalWritable` 
parameter. However array parameters are converted to  
`ArrayList<HiveDecimalWritable>` before they passed. This leads to a 
`ClassCastException`.


Diffs (updated)
-----

  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentileCont.java
 e7e4fda6ea 
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentileDisc.java
 d7c295cb11 
  ql/src/test/queries/clientpositive/udaf_percentile_cont.q 7a1ac5c968 
  ql/src/test/queries/clientpositive/udaf_percentile_disc.q 6d93b3418a 
  ql/src/test/results/clientpositive/udaf_percentile_cont.q.out a2dae4a06e 
  ql/src/test/results/clientpositive/udaf_percentile_disc.q.out 3ef0cf9874 


Diff: https://reviews.apache.org/r/71571/diff/2/

Changes: https://reviews.apache.org/r/71571/diff/1-2/


Testing
-------

Existing q tests are extended with calling percentile_cont/disc with array 
parameters


Thanks,

Krisztian Kasa

Reply via email to