> On Nov. 5, 2019, 10:11 a.m., Zoltan Haindrich wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliAdapter.java > > Lines 82-93 (patched) > > <https://reviews.apache.org/r/71711/diff/1/?file=2170995#file2170995line82> > > > > these things should not be part of the "adapter" as it breaks its > > adapter contract
a bit confused about this one I've put this logic into CliAdapter, because this way all the drivers will inherit the metastore configuration behavior without any modification (tested it) 1. what kind of contract does this break? 2. where else could I put this? > On Nov. 5, 2019, 10:11 a.m., Zoltan Haindrich wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliAdapter.java > > Lines 121 (patched) > > <https://reviews.apache.org/r/71711/diff/1/?file=2170995#file2170995line121> > > > > firstTestNotYetRun - sounds like pretty hairy :D > > how far are the contents of this if's body to be considered beforeClass > > kinda stuff? - would that work? firstTestNotYetRun: it's a hack because of my current junit knowledge it can protect from doing some things twice, e.g. double initialization for the first test case in a particular test class (class level + test level initialization) > On Nov. 5, 2019, 10:11 a.m., Zoltan Haindrich wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreAccumuloCliDriver.java > > Lines 54-57 (original) > > <https://reviews.apache.org/r/71711/diff/1/?file=2170996#file2170996line55> > > > > right now I guess I don't see every doors and corners around > > here...but might be an alternate approach would be to concentrate the > > common part to some abstract between all the drivers and the cliadapter - > > might help clean up existing stuff as well... let me handle this in a follow-up patch, I wanted to create another patch about handling cli driver cleanup > On Nov. 5, 2019, 10:11 a.m., Zoltan Haindrich wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/schematool/MetastoreSchemaTool.java > > Line 199 (original), 199 (patched) > > <https://reviews.apache.org/r/71711/diff/1/?file=2171020#file2171020line199> > > > > why did the signature of this method changed? this is just for fluency, i used this while developing like schemaTool = new MetastoreSchemaTool(...).setVerbose(true) maybe it's not part of the patch anymore, but I like this setVerbose in this way - Laszlo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71711/#review218500 ----------------------------------------------------------- On Nov. 2, 2019, 1:34 p.m., Laszlo Bodor wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71711/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2019, 1:34 p.m.) > > > Review request for hive, Zoltan Haindrich and Peter Vary. > > > Repository: hive-git > > > Description > ------- > > HIVE-21954: QTest: support for running qtests on various metastore DBs > > > Diffs > ----- > > data/conf/perf-reg/spark/hive-site.xml 15ec63048e > data/conf/perf-reg/tez/hive-site.xml 2951f30531 > data/scripts/q_test_init.sql df0582814a > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestLocationQueries.java > eb3b935f09 > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestMTQueries.java > 3e0cdac67c > itests/qtest/pom.xml 364d07f9d9 > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/AbstractCoreBlobstoreCliDriver.java > 50417e9378 > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliAdapter.java > 574a67f2e3 > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreAccumuloCliDriver.java > 9a23ef855e > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java > c8239a731c > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreCliDriver.java > d06acfb978 > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreCompareCliDriver.java > 62ea96089a > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreDummy.java > 301b91e54e > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreHBaseCliDriver.java > 40545d8d65 > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreHBaseNegativeCliDriver.java > 6094e6dffb > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreKuduCliDriver.java > 71134e7b0a > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreKuduNegativeCliDriver.java > 4f6988c9f3 > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreNegativeCliDriver.java > bb9e65524d > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CorePerfCliDriver.java > 59c71f544c > > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestMetaStoreHandler.java > PRE-CREATION > > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestSystemProperties.java > f82d17e5b3 > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java > 9856a30381 > > itests/util/src/main/java/org/apache/hadoop/hive/ql/parse/CoreParseNegative.java > 9a136e24f0 > pom.xml 6dbff132cd > ql/src/test/queries/clientpositive/create_func1.q 2c6acfc291 > ql/src/test/queries/clientpositive/partition_params_postgres.q PRE-CREATION > ql/src/test/results/clientpositive/create_func1.q.out 238d378cda > ql/src/test/results/clientpositive/llap/sysdb.q.out af06f5050e > ql/src/test/results/clientpositive/partition_params_postgres.q.out > PRE-CREATION > ql/src/test/results/clientpositive/show_functions.q.out 9db684579b > standalone-metastore/DEV-README 9c261171fb > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java > 49e19adf71 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/schematool/MetastoreSchemaTool.java > 27b0483c01 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/DbInstallBase.java > 6d8fd46f2a > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/ITestMysql.java > 9999d8d705 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/ITestOracle.java > 5b93e0ffae > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/ITestPostgres.java > 9151ac766e > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/ITestSqlServer.java > 67b6eeeab2 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/DatabaseRule.java > PRE-CREATION > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/Derby.java > PRE-CREATION > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/Mssql.java > PRE-CREATION > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/Mysql.java > PRE-CREATION > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/Oracle.java > PRE-CREATION > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/Postgres.java > PRE-CREATION > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/tools/schematool/TestMetastoreSchemaTool.java > b4a0844be3 > > > Diff: https://reviews.apache.org/r/71711/diff/1/ > > > Testing > ------- > > precommit tests green > > + > > mvn test -Dtest.output.overwrite=true -Pitests -pl itests/qtest > -Dtest=TestCliDriver -Dqfile=partition_params_postgres.q > -Dtest.metastore.db=mssql > mvn test -Dtest.output.overwrite=true -Pitests -pl itests/qtest > -Dtest=TestCliDriver -Dqfile=partition_params_postgres.q > -Dtest.metastore.db=mysql > mvn test -Dtest.output.overwrite=true -Pitests -pl itests/qtest > -Dtest=TestCliDriver -Dqfile=partition_params_postgres.q > -Dtest.metastore.db=postgres > mvn test -Dtest.output.overwrite=true -Pitests -pl itests/qtest > -Dtest=TestCliDriver -Dqfile=partition_params_postgres.q > -Dtest.metastore.db=oracle > -Ditest.jdbc.jars=/path/to/your/god/damn/oracle/jdbc/driver/ojdbc6.jar > > > Thanks, > > Laszlo Bodor > >
