-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71784/
-----------------------------------------------------------
(Updated Nov. 21, 2019, 9:40 a.m.)
Review request for hive, Laszlo Bodor, Harish Jaiprakash, Mustafa Iman, and
Panos Garefalakis.
Changes
-------
test might be flaky, ignore it until we find a better solution
Bugs: HIVE-22514
https://issues.apache.org/jira/browse/HIVE-22514
Repository: hive-git
Description
-------
HiveProtoLoggingHook uses a ScheduledThreadPoolExecutor to submit writer tasks
and to periodically handle rollover. The builtin ScheduledThreadPoolExecutor
uses a unbounded queue which cannot be replaced from the outside. If log events
are generated at a very fast rate this queue can grow large.
Since ScheduledThreadPoolExecutor does not support changing the default
unbounded queue to a bounded one, the queue capacity is checked manually by the
patch.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a7687d59004
ql/src/java/org/apache/hadoop/hive/ql/hooks/HiveProtoLoggingHook.java
8eab54859bf
ql/src/test/org/apache/hadoop/hive/ql/hooks/TestHiveProtoLoggingHook.java
450a0b544d6
Diff: https://reviews.apache.org/r/71784/diff/2/
Changes: https://reviews.apache.org/r/71784/diff/1-2/
Testing
-------
unittest
Thanks,
Attila Magyar
