----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71812/#review218820 -----------------------------------------------------------
Since everybody can comment on logging, I have a few comments :) Thanks! ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactorFactory.java Lines 24-25 (patched) <https://reviews.apache.org/r/71812/#comment306703> Is this needed? ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java Lines 122 (patched) <https://reviews.apache.org/r/71812/#comment306704> Maybe log the exception? ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java Lines 140 (patched) <https://reviews.apache.org/r/71812/#comment306705> Log the exception ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java Line 234 (original), 239 (patched) <https://reviews.apache.org/r/71812/#comment306706> There were other occurences for logging InterruptedException - then we decided not to log the full exception, just the message. Maybe we should handle InterruptedException in the same way - one, or the other (I prefer the full stack, but whatever) - Peter Vary On nov. 25, 2019, 12:18 du, Laszlo Pinter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71812/ > ----------------------------------------------------------- > > (Updated nov. 25, 2019, 12:18 du) > > > Review request for hive, Denys Kuzmenko and Peter Vary. > > > Repository: hive-git > > > Description > ------- > > HIVE-22534: ACID: Improve Compactor thread logging > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > ee2c0f3e23ed716f3de0a2740a96a7ec39251bc2 > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MajorQueryCompactor.java > 10681c0202a32c338e58b3e2eede03657a00774f > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MmMajorQueryCompactor.java > f7e0a85c1f595bb4f112aa051779db3f00c8e572 > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java > 80119de22f602d9e3cb7a1f60b48e05a37c6a047 > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactorFactory.java > 41cb4b64fbc79dcf81919769c567b26a2e18cfe5 > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java > 3270175a80992e0efb1e0bfd1f33ffd8a96fcf87 > > > Diff: https://reviews.apache.org/r/71812/diff/2/ > > > Testing > ------- > > > Thanks, > > Laszlo Pinter > >
