-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71835/
-----------------------------------------------------------
(Updated Dec. 9, 2019, 12:12 p.m.)
Review request for hive, Jesús Camacho Rodríguez and Zoltan Haindrich.
Bugs: HIVE-22508
https://issues.apache.org/jira/browse/HIVE-22508
Repository: hive-git
Description
-------
KeyWrapperComparator throws exception
=====================================
1. Check the `KeyWrapper` instances whether they are a clones and use the
corresponding object inspectors.
2. `NullValueOption.MINVALUE` and `MAXVALUE` was switched in `NullOrdering`
enum and hypothetical set functions produced bad return values in case of NULL
inputs.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/KeyWrapper.java fee8081652
ql/src/java/org/apache/hadoop/hive/ql/exec/KeyWrapperComparator.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/KeyWrapperFactory.java f1bf9023e1
ql/src/java/org/apache/hadoop/hive/ql/exec/TopNKeyOperator.java 4e35922e5f
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/wrapper/VectorHashKeyWrapperBase.java
1bb224917e
ql/src/java/org/apache/hadoop/hive/ql/util/NullOrdering.java 46ff329981
ql/src/test/queries/clientpositive/hypothetical_set_aggregates.q 6b5f3765e9
ql/src/test/results/clientpositive/hypothetical_set_aggregates.q.out
3ea6f1f4e5
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
1f3bbaf87d
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestObjectInspectorUtilsCompare.java
PRE-CREATION
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestObjectInspectorUtilsCompareNull.java
PRE-CREATION
Diff: https://reviews.apache.org/r/71835/diff/2/
Changes: https://reviews.apache.org/r/71835/diff/1-2/
Testing
-------
Run q tests using TestMiniLlapLocalCliDriver
topnkey_order_null.q
TestCliDriver
hypothetical_set_aggregates.q
Thanks,
Krisztian Kasa
