-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71984/
-----------------------------------------------------------
(Updated Jan. 22, 2020, 7:30 a.m.)
Review request for hive and Jesús Camacho Rodríguez.
Bugs: HIVE-22666
https://issues.apache.org/jira/browse/HIVE-22666
Repository: hive-git
Description
-------
implement supporting partitioning in TopNKeyOperator
enable push down of partitioned TopNKeyOperator
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/TopNKeyOperator.java b7c1250220
ql/src/java/org/apache/hadoop/hive/ql/optimizer/topnkey/TopNKeyProcessor.java
ce6efa4919
ql/src/java/org/apache/hadoop/hive/ql/optimizer/topnkey/TopNKeyPushdownProcessor.java
348fbb5faf
ql/src/java/org/apache/hadoop/hive/ql/plan/TopNKeyDesc.java f752967a96
ql/src/test/org/apache/hadoop/hive/ql/exec/TestTopNKeyFilter.java
PRE-CREATION
ql/src/test/queries/clientpositive/subquery_in.q a5b3ce7951
ql/src/test/queries/clientpositive/subquery_notin.q f8636453c2
ql/src/test/queries/clientpositive/topnkey_windowing.q PRE-CREATION
ql/src/test/queries/clientpositive/topnkey_windowing_order.q PRE-CREATION
ql/src/test/queries/clientpositive/vector_windowing_streaming.q e1011f9949
ql/src/test/queries/clientpositive/windowing_filter.q 2483c18416
ql/src/test/results/clientpositive/llap/subquery_in.q.out 4f0e75289f
ql/src/test/results/clientpositive/llap/subquery_notin.q.out 67e349bb59
ql/src/test/results/clientpositive/llap/topnkey_windowing.q.out PRE-CREATION
ql/src/test/results/clientpositive/llap/topnkey_windowing_order.q.out
PRE-CREATION
ql/src/test/results/clientpositive/perf/tez/constraints/mv_query44.q.out
786bbe12c8
ql/src/test/results/clientpositive/perf/tez/constraints/query44.q.out
eace7a0685
ql/src/test/results/clientpositive/perf/tez/constraints/query67.q.out
9ed7306c46
ql/src/test/results/clientpositive/perf/tez/constraints/query70.q.out
40dfaa2f13
ql/src/test/results/clientpositive/perf/tez/query44.q.out a0defab8b3
ql/src/test/results/clientpositive/perf/tez/query67.q.out 54d76e9c1a
ql/src/test/results/clientpositive/perf/tez/query70.q.out 23f9166a4f
ql/src/test/results/clientpositive/topnkey_windowing.q.out PRE-CREATION
ql/src/test/results/clientpositive/topnkey_windowing_order.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/71984/diff/5/
Changes: https://reviews.apache.org/r/71984/diff/4-5/
Testing
-------
New q test were added
topnkey_windowing.q,topnkey_windowing_order.q
New UT:
TestTopNKeyFilter.java
existing:
windowing_filter.q,topnkey.q,topnkey_grouping_sets.q,topnkey_grouping_sets_functions.q,topnkey_grouping_sets_order.q
existing UT:
TestCommonKeyPrefix
Thanks,
Krisztian Kasa
