----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72129/ -----------------------------------------------------------
Review request for hive, Gopal V, Peter Vary, and Zoltan Chovan. Repository: hive-git Description ------- - Main change is in TxnHandler::checkLock. - When all incoming requests are SHARED_READ, we can add a condition in the query to retrieve only relevant rows. This avoids significant number of rows fetched in the form of "SHARED_READ + ACQUIRED". There is a corner condition of "SHARED_WRITE --> SHARED_READ::ACQUIRED", which is misleading in the jumpttable. This condition can be optimised later. - Also, removed the "HL_PARTITION IN" clause which could potentially overflow for oracle. Partition details can be filtered out, if the earlier query actually returned any rows. - Rest of the changes, are related to refactoring "TxnHandler::enqueueLockWithRetry" to reduce lock scope. Diffs ----- standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java f53aebe4ad Diff: https://reviews.apache.org/r/72129/diff/1/ Testing ------- Thanks, Rajesh Balamohan