> On Jan. 31, 2020, 9:52 a.m., Peter Vary wrote: > > Have you tested the sqls on every db? > > If they run correctly on all supported DB, then +1 from my side > > > > Thanks, > > Peter
Run tests on derby, mssql, mysql, oracle and postgres. All passed. - Laszlo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72043/#review219380 ----------------------------------------------------------- On Jan. 24, 2020, 10 a.m., Laszlo Pinter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72043/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2020, 10 a.m.) > > > Review request for hive, Denys Kuzmenko, Karen Coppage, and Peter Vary. > > > Repository: hive-git > > > Description > ------- > > HIVE-21487: COMPLETED_COMPACTIONS and COMPACTION_QUEUE table missing > appropriate indexes > > > Diffs > ----- > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java > 7f1c2f8bdcc5a43a816e4cf7461e28e8eacb8511 > > standalone-metastore/metastore-server/src/main/sql/derby/hive-schema-4.0.0.derby.sql > 482d8aa1630ab854754892f9181cecc3ca12568d > > standalone-metastore/metastore-server/src/main/sql/derby/upgrade-3.2.0-to-4.0.0.derby.sql > 6fd8ae64cb26ab10ba271afa3ec02d54b0f68a97 > > standalone-metastore/metastore-server/src/main/sql/mssql/hive-schema-4.0.0.mssql.sql > dfd4bd6672459e1431273cd24464a1aa5732803e > > standalone-metastore/metastore-server/src/main/sql/mssql/upgrade-3.2.0-to-4.0.0.mssql.sql > fecfca8c13af42ed871ef632ef7d11cea15ff613 > > standalone-metastore/metastore-server/src/main/sql/mysql/hive-schema-4.0.0.mysql.sql > a9a09307ee53a44ea583990b772dff406cd1d96a > > standalone-metastore/metastore-server/src/main/sql/mysql/upgrade-3.2.0-to-4.0.0.mysql.sql > 70b5d9d41ffd91d4729b3518d4bfdb4bf14c3165 > > standalone-metastore/metastore-server/src/main/sql/oracle/hive-schema-4.0.0.oracle.sql > f90d76b4e0c070432a0ac6fe0261f5d72155bb5b > > standalone-metastore/metastore-server/src/main/sql/oracle/upgrade-3.2.0-to-4.0.0.oracle.sql > 9f1b98037234b9cbb214181d5ea4987b3a476667 > > standalone-metastore/metastore-server/src/main/sql/postgres/hive-schema-4.0.0.postgres.sql > b992d7a24904d6fbe47e69256916aa69eaddea02 > > standalone-metastore/metastore-server/src/main/sql/postgres/upgrade-3.2.0-to-4.0.0.postgres.sql > f9af248e279f519aeb0d3a6d46a678dbd8f431c1 > > > Diff: https://reviews.apache.org/r/72043/diff/5/ > > > Testing > ------- > > > Thanks, > > Laszlo Pinter > >
