----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71783/ -----------------------------------------------------------
Review request for hive, Gopal V, Jesús Camacho Rodríguez, Krisztian Kasa, and Panos Garefalakis. Bugs: HIVE-22925 https://issues.apache.org/jira/browse/HIVE-22925 Repository: hive-git Description ------- In certain cases the TopNKey filter might work in an inefficient way and adds extra CPU overhead. For example if the rows are coming in an ascending order but the filter wants the top N smallest elements the filter will forward everything. Inefficient should be detected in runtime so that the filter can be disabled of the ration between forwarder_rows/total_rows is too high. Diffs ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java e419dc5eb3b ql/src/java/org/apache/hadoop/hive/ql/exec/TopNKeyFilter.java 38d2e08b760 ql/src/java/org/apache/hadoop/hive/ql/exec/TopNKeyOperator.java dd66dfcd72e ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorTopNKeyOperator.java 7feadd3137d ql/src/java/org/apache/hadoop/hive/ql/optimizer/topnkey/TopNKeyProcessor.java 3869ffa2b83 ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java 31735c9ea3d ql/src/java/org/apache/hadoop/hive/ql/plan/TopNKeyDesc.java 19910a341e0 ql/src/test/org/apache/hadoop/hive/ql/exec/TestTopNKeyFilter.java 95cd45978a8 Diff: https://reviews.apache.org/r/71783/diff/1/ Testing ------- on dwx Thanks, Attila Magyar