----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72291/#review220153 -----------------------------------------------------------
Ship it! Just a question, maybe not relevant. Thanks for the patch LGTM +1 (pending tests :)) standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java Lines 545-560 (original), 496-512 (patched) <https://reviews.apache.org/r/72291/#comment308477> How confident we are with this query? Maybe delete immediately, like: DELETE FROM TXN_TO_WRITE_ID WHERE T2W_TXNID < (SELECT MIN...) The hard part is that it is hard to log what happened - Peter Vary On márc. 31, 2020, 1:51 du, Laszlo Pinter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72291/ > ----------------------------------------------------------- > > (Updated márc. 31, 2020, 1:51 du) > > > Review request for hive and Peter Vary. > > > Repository: hive-git > > > Description > ------- > > HIVE-23107: Remove MIN_HISTORY_LEVEL table > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java > 54b616e60c73fa1005c6d679ea76d65e01a0749d > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionInfo.java > bf91ae704c83722502acaf445061bf297fde6a6f > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java > 19a95b64db64b7f8bf8e82fbdedf5b54cd30aed3 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java > ef88240a791cbc553b6150b54701c7df8daf3b49 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 74ef88545e6fd680b311ca5c5e4d87f053af1026 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnStore.java > 41d2e7924b1286f82d212e051714107505fe9661 > > standalone-metastore/metastore-server/src/main/sql/derby/hive-schema-4.0.0.derby.sql > 48ad67623143fcba2bb2507cc36ad46a58c13b75 > > standalone-metastore/metastore-server/src/main/sql/derby/upgrade-3.2.0-to-4.0.0.derby.sql > 7a230bde3a4dcd2504538bf8122db0bb2a59932f > > standalone-metastore/metastore-server/src/main/sql/mssql/hive-schema-4.0.0.mssql.sql > 9ed7f4f8192e1613f8942af3e9496c3ef7f1f04f > > standalone-metastore/metastore-server/src/main/sql/mssql/upgrade-3.2.0-to-4.0.0.mssql.sql > 12d24e9a569310c57d86b1229deaa2b1d080e0b8 > > standalone-metastore/metastore-server/src/main/sql/mysql/hive-schema-4.0.0.mysql.sql > bc34b511a978af2a6704e47d8f73c9604c6cebf9 > > standalone-metastore/metastore-server/src/main/sql/mysql/upgrade-3.2.0-to-4.0.0.mysql.sql > 13f03bce6d579c18ff9a14e09133063fdcdbf7af > > standalone-metastore/metastore-server/src/main/sql/oracle/hive-schema-4.0.0.oracle.sql > 8482b5942c6284eda63ec7d2aa7c1202abb3db49 > > standalone-metastore/metastore-server/src/main/sql/oracle/upgrade-3.2.0-to-4.0.0.oracle.sql > cbfdd861fd545ce786f5e267b284196f5fd9af03 > > standalone-metastore/metastore-server/src/main/sql/postgres/hive-schema-4.0.0.postgres.sql > aa35a7a7b392d4d46480c03ed95ffdec12b03b22 > > standalone-metastore/metastore-server/src/main/sql/postgres/upgrade-3.2.0-to-4.0.0.postgres.sql > 9462328a5f0c6dda8cffb683860153b8eb3aacec > > > Diff: https://reviews.apache.org/r/72291/diff/1/ > > > Testing > ------- > > > Thanks, > > Laszlo Pinter > >
